receiptsmigration detection on windows is faulty if krew itself fails to install

[ahmetb]

If I try to install krew on windows and fail halfway and receipts/krew.yaml is not written, krew will end up in a situation that requires kubectl krew system receipts-upgrade.

This happens because we look at store/ dir which is not empty. But in this case of a bug (like #357) store/krew/ is actually an empty dir.

krew/pkg/receiptsmigration/migration.go

Lines 42 to 63 in 7bd3969

	func Done(newPaths environment.Paths) (bool, error) {
	receipts, err := ioutil.ReadDir(newPaths.InstallReceiptsPath())
	if err != nil {
	return false, err
	}
	store, err := ioutil.ReadDir(newPaths.InstallPath())
	if err != nil {
	return false, err
	}
	var hasInstalledPlugins bool
	for _, entry := range store {
	if entry.IsDir() {
	hasInstalledPlugins = true
	break
	}
	}
	hasNoReceipts := len(receipts) == 0
	return !(hasInstalledPlugins && hasNoReceipts), nil
	}

What if we instead looked at entries under bin/ directory?

/area platform/windows
/priority P2

[ahmetb]

/assign @corneliusweig

[corneliusweig]

Yes, that should indeed be more stable. Let's check if there is at least one symlink starting with kubectl-.

[ahmetb]

SGTM. That would ensure a plugin installed with krew exists (incl krew itself) so it would ensure krew is installed at least :)