Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move platform detection to pkg/installation #286

Merged
merged 3 commits into from Jul 22, 2019
Merged

Move platform detection to pkg/installation #286

merged 3 commits into from Jul 22, 2019

Commits on Jul 22, 2019

  1. Move platform detection to pkg/installation 

    - moved Platform matching methods to pkg/installation, where:
  - they make more sense
  - they can be tested without worrying about cyclic imports due to pkg/testutil.
- rewrote some tests in platform_test.go to be shorter.
- added a test for "no platforms specified" case in TestValidatePlugin.

- added a check to verify-code-patterns that uses a heuristic to detect inline
  initializations of index.(Plugin|Platform) structs.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
    @ahmetb
    ahmetb committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    bc7357b View commit details
    Browse the repository at this point in the history

  2. Address code review comments 

    Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
    @ahmetb
    ahmetb committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    226fd68 View commit details
    Browse the repository at this point in the history

  3. Fix regexp 

    Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
    @ahmetb
    ahmetb committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    8d3c7a0 View commit details
    Browse the repository at this point in the history