Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELEASING_KREW: Specify the repository to push the tag to #373

Merged
merged 1 commit into from Nov 10, 2019

Conversation

corneliusweig
Copy link
Contributor

When pushing individual tags, specifying the repos is mandatory.

I also wasn't aware of this when reviewing #369 馃

/assign @ahmetb

When pushing individual tags, specifying the repos is mandatory.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 10, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 10, 2019
@codecov-io
Copy link

Codecov Report

Merging #373 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #373   +/-   ##
======================================
  Coverage    57.2%   57.2%           
======================================
  Files          19      19           
  Lines         916     916           
======================================
  Hits          524     524           
  Misses        339     339           
  Partials       53      53

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 612112f...8d55a95. Read the comment docs.

@ahmetb
Copy link
Member

ahmetb commented Nov 10, 2019

Oh yeah I think I corrected this in the shell, but forgot to update docs.
/lgtm
/approve

Thanks for catching.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 908b7ad into kubernetes-sigs:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants