pkg/kubectl: check version of kubectl #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @lbb |
If someone tries to execute krew binary standalone with kubectl <1.12, adding a failure. I'm not entirely sure if it's a valid use case. The only encounter of this could be when someone installs krew, and directly tries to invoke the binary (as krew 0.2 won't work on kubectl 1.11 or older). Probably harmless for now (also added a KREW_DISABLE_KUBECTL_VERSION_CHECK escape hatch for dev/build purposes). We can remove this pkg and check soon. Currently adds ~100 ms to each krew cmd. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
ahmetb
force-pushed
the
kubectl-version-detect
branch
from
1751b5c
to
a1847aa
Compare
lbb
suggested changes
Sep 17, 2018
| // detect kubectl version to prevent running krew standalone with older | ||
| // versions of kubectl. | ||
| // TODO(ahmetb): this may not be necessary after most users are on 1.12 | ||
| glog.V(4).Infof("checking kubectl version") |
| @@ -19,6 +19,8 @@ import ( | |||
| "fmt" | |||
| "os" | |||
|
|
|||
| "github.com/GoogleContainerTools/krew/pkg/kubectl" | |||
|
|
|||
| glog.V(4).Infof("checking kubectl version") | ||
| ok, err := kubectl.IsSupportedVersion() | ||
| if err != nil { | ||
| glog.Fatalf("error checking kubectl version: %+v", err) |
| glog.Fatal("You are running on an unsupported version of \"kubectl\"." + | ||
| " This version of krew requires minimum kubectl 1.12.0.") | ||
| } | ||
| glog.V(4).Infof("checked kubectl version") |
|
|
||
| var ( | ||
| minKubectl = semver.New("1.12.0-alpha.0") | ||
| versionProvider = execKubectlVersion |
There was a problem hiding this comment.
this is for mocking easily.
| cmd := exec.Command("kubectl", "version", "--client", "--output=json") | ||
| b, err := cmd.CombinedOutput() | ||
| if err != nil { | ||
| return "", fmt.Errorf("failed to execute kubectl version. error=%v, out=%v", err, string(b)) |
There was a problem hiding this comment.
put the cascading error at the end of the message
|
/hold |
Closed
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone tries to execute krew binary standalone with kubectl <1.12, adding
a failure.
I'm not entirely sure if it's a valid use case. The only encounter of this
could be when someone installs krew, and directly tries to invoke the binary
(as krew 0.2 won't work on kubectl 1.11 or older).
Probably harmless for now (also added a KREW_DISABLE_KUBECTL_VERSION_CHECK
escape hatch for dev/build purposes). We can remove this pkg and check soon.
Currently adds ~100 ms to each krew cmd.