Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add krew logo assets #499

Merged
merged 1 commit into from Feb 8, 2020
Merged

Add krew logo assets #499

merged 1 commit into from Feb 8, 2020

Conversation

iboonox
Copy link
Contributor

@iboonox iboonox commented Feb 8, 2020

Fixes #437

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 8, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @iboonox!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 8, 2020
@iboonox iboonox mentioned this pull request Feb 8, 2020
@corneliusweig
Copy link
Contributor

corneliusweig commented Feb 8, 2020

Hey @iboonox, thanks again for your great work! Looks like you still need to sign the Linux foundation CLA, let me know if you encounter problems here. I just saw that everything is good now.

I wonder if we should merge the PNG files into the repository. They are binary files and those do not play well with git (everybody needs to download all revisions when cloning a repo). Given that the SVG files are superior vector graphics and display the same, I see no reason why we should also add the PNGs. WDYT?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 8, 2020
@codecov-io
Copy link

codecov-io commented Feb 8, 2020

Codecov Report

Merging #499 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files          22       22           
  Lines         969      969           
=======================================
  Hits          567      567           
  Misses        346      346           
  Partials       56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c0e20...8552fbb. Read the comment docs.

@ahmetb
Copy link
Member

ahmetb commented Feb 8, 2020

Thanks a lot this makes me so happy! 💕

We could probably minify, but it’s ok.
Do you mind sending src files for future maintainers later on?

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, iboonox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 14f129f into kubernetes-sigs:master Feb 8, 2020
@ahmetb
Copy link
Member

ahmetb commented Feb 9, 2020

I wonder if we should merge the PNG files into the repository. They are binary files and those do not play well with git (everybody needs to download all revisions when cloning a repo). Given that the SVG files are superior vector graphics and display the same, I see no reason why we should also add the PNGs. WDYT?

I think PNG is fine for now. Especially for ease of use in blog posts etc, I suspect they'll be needed.

PNGs are also easier to work with, e.g. people can easily mash it up with other pictures, or resize etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design a logo for Krew
5 participants