Convert dashes in plugin names to underscores #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @lbb |
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 41.49% 42.18% +0.68%
==========================================
Files 12 12
Lines 547 550 +3
==========================================
+ Hits 227 232 +5
+ Misses 273 272 -1
+ Partials 47 46 -1
Continue to review full report at Codecov.
|
For dashes to be preserved in a plugin's name, its executable name must convert
dashes to underscores.
For example a plugin named "foo-bar" would today be linked as:
kubectl-foo-bar
therefore, it can only be invoked as:
kubectl foo bar
However, linking the same plugin as:
kubectl-foo_bar
allows plugin to be called as:
kubectl foo-bar
kubectl foo_bar
- convert OS detection pluginNameToBin() to explicit input for testability
- test pluginNameToBin().
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
ahmetb
force-pushed
the
underscoring
branch
from
a0631a4
to
51b71cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For dashes to be preserved in a plugin's name, its executable name must convert
dashes to underscores.
For example a plugin named "foo-bar" would today be linked as:
therefore, it can only be invoked as:
However, linking the same plugin as:
allows plugin to be called as:
Fixes #59.