Allow mocking of url downloads with local file (--archive) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 47.8% 47.32% -0.48%
==========================================
Files 12 12
Lines 592 598 +6
==========================================
Hits 283 283
- Misses 262 268 +6
Partials 47 47
Continue to review full report at Codecov.
|
ahmetb
force-pushed
the
mock-file
branch
2 times, most recently
from
7e1643a
to
bc25679
Compare
|
@lbb wdyt of this |
ahmetb
changed the title
ahmetb
force-pushed
the
mock-file
branch
5 times, most recently
from
e9544ae
to
000f7dc
Compare
|
Ready for review. |
- rename --source to --manifest in install command.
- introduce --archive flag to install command to override the installation from
the uri specified in the manifest file.
- remove getFileFromArg() method (not needed)
This patch allows specifying both plugin yamls and archives to install cmd:
krew install --manifest foo.yaml --archive foo.zip
It does not download a file, but it still checks integrity (so it can be used to
check the manifest without uploading the archive anywhere).
The method signatures got very long but I think that's partially because
we probably didn't design the methods in install.go well (the code smell here
is the repetitive args passed from one method to another all the way down).
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the uri specified in the manifest file.
This patch allows specifying both plugin yamls and archives to install cmd:
It does not download a file, but it still checks integrity (so it can be used to
check the manifest without uploading the archive anywhere).
The method signatures got very long but I think that's partially because
we probably didn't design the methods in install.go well (the code smell here
is the repetitive args passed from one method to another all the way down).