Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding clarity for plugin repo naming #760

Merged
merged 1 commit into from Mar 28, 2022

Conversation

rothgar
Copy link
Contributor

@rothgar rothgar commented Mar 28, 2022

I'm adding this based on convention I've seen with other plugins but if there's something else we recommend I'm fine with that too. This clarity can help plugin developers and companies looking for naming guidance and who want to avoid any trademark confusion.

Fixes #...
Related issue: #...

I'm adding this based on convention I've seen with other plugins but if there's something else we recommend I'm fine with that too. This clarity can help plugin developers and companies looking for naming guidance and who want to avoid any trademark confusion.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 28, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rothgar / name: Justin Garrison (3812f60)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 28, 2022
@ahmetb
Copy link
Member

ahmetb commented Mar 28, 2022

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, rothgar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit eda76d9 into kubernetes-sigs:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants