Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EXTERNAL_IMPORT_ENABLED environment variables #102

Merged
merged 6 commits into from
Feb 13, 2022
Merged

Add EXTERNAL_IMPORT_ENABLED environment variables #102

merged 6 commits into from
Feb 13, 2022

Conversation

196Ikuchil
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add EXTERNAL_IMPORT_ENABLED environment variables it indicates whether the scheduler should enable the function to import from an existing cluster.
Eventually, we would like to implement #41 .

Which issue(s) this PR fixes:

Relates #41

Special notes for your reviewer:

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 11, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @196Ikuchil. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 11, 2022
@196Ikuchil
Copy link
Contributor Author

/assign @sanposhiho

@196Ikuchil 196Ikuchil mentioned this pull request Feb 11, 2022
Closed
sanposhiho
sanposhiho reviewed Feb 12, 2022
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One nits:

config/config.go Outdated
@@ -16,12 +16,14 @@ import (
var ErrEmptyEnv = errors.New("env is needed, but empty")

// Config is configuration for simulator.
// ExternalImportEnabled indicates whether the scheduler should enable the function to import from an existing cluster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move on to ExternalImportEnabled field. (between L24 and L25)

@sanposhiho
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 12, 2022
@196Ikuchil
Copy link
Contributor Author

Thank you for the review! I fixed it.

sanposhiho
sanposhiho reviewed Feb 12, 2022
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two nits

config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
196Ikuchil and others added 2 commits February 13, 2022 09:36
@196Ikuchil @sanposhiho
Update config/config.go
f50d3d9 
Co-authored-by: Kensei Nakada <handbomusic@gmail.com>
@196Ikuchil @sanposhiho
Update config/config.go
7207e91 
Co-authored-by: Kensei Nakada <handbomusic@gmail.com>
@196Ikuchil
Copy link
Contributor Author

196Ikuchil commented Feb 13, 2022 •
edited
Loading

@sanposhiho Thanks! Approved your suggestion.
Why is the backend-lint failed?


pull-kube-scheduler-simulator-backend-lint — Pod got deleted unexpectedly

@sanposhiho
Copy link
Member

The platform issue, maybe?
/retest

sanposhiho
sanposhiho approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 196Ikuchil, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 92fa0a6 into kubernetes-sigs:master Feb 13, 2022
@196Ikuchil 196Ikuchil mentioned this pull request Mar 31, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho approved these changes

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@196Ikuchil @k8s-ci-robot @sanposhiho