Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the delete button when the selected priorityclass is the system one #104

Merged
merged 4 commits into from
Feb 13, 2022
Merged

Disable the delete button when the selected priorityclass is the system one #104

merged 4 commits into from
Feb 13, 2022

Conversation

196Ikuchil
Copy link
Contributor

@196Ikuchil 196Ikuchil commented Feb 11, 2022 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

We turn off the delete button when the selected priorityclass is created by k8s.

  • The name of it prefixed with system- is reserved by the system and it can't be deleted.
    Reference

To implement that logic, we added a new field on SelectedItem interface.

Which issue(s) this PR fixes:

Fixes #99

Special notes for your reviewer:

For the general
スクリーンショット 2022-02-11 20 33 02

For the system
スクリーンショット 2022-02-11 20 32 42

Even now, the apply/edit button is still enabled.
This is because even if the PriorityClass is the system one, description field, for example, is editable.

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 11, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @196Ikuchil. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2022
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Feb 11, 2022
@sanposhiho
Copy link
Member

/assign

sanposhiho
sanposhiho reviewed Feb 12, 2022
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) One comment.

web/store/node.ts Outdated
@@ -39,6 +40,7 @@ export default function nodeStore() {
isNew: isNew,
item: n,
resourceKind: "Node",
isDeletable: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why false? Maybe should be true.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, my mistake... I have fixed it.

196Ikuchil and others added 2 commits February 13, 2022 00:34
@196Ikuchil @sanposhiho
Update web/store/priorityclass.ts
806c3e8 
Co-authored-by: Kensei Nakada <handbomusic@gmail.com>
@196Ikuchil
fix:change default value of node
3842b20
@sanposhiho
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 12, 2022
sanposhiho
sanposhiho reviewed Feb 13, 2022
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 196Ikuchil, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit d70700b into kubernetes-sigs:master Feb 13, 2022
@196Ikuchil 196Ikuchil mentioned this pull request Mar 31, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho left review comments

@adtac adtac Awaiting requested review from adtac

Assignees

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WebUI] Delete button of high privileged PriorityClass
3 participants
@196Ikuchil @k8s-ci-robot @sanposhiho