Rename the environment variable FRONTEND_URL to CORS_ALLOWED_ORIGIN_LIST and accept list #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
sig/scheduling
k8s-ci-robot
added
approved
196Ikuchil
reviewed
Apr 30, 2022
| if e == "" { | ||
| return "", xerrors.Errorf("get FRONTEND_URL from env: %w", ErrEmptyEnv) | ||
| return nil, xerrors.Errorf("get CORS_ALLOWED_ORIGIN_LIST from env: %w", ErrEmptyEnv) |
There was a problem hiding this comment.
Should we also raise an error if the URL is informal? (Or fix to return ""?)
k8s-ci-robot
added
size/L
|
Thanks! |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
Rename the environment variable FRONTEND_URL to CORS_ALLOWED_ORIGIN_LIST and accept list.
Which issue(s) this PR fixes:
Fixes #156
Special notes for your reviewer:
/label tide/merge-method-squash