Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md about memory allocation to Docker #30

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Update README.md about memory allocation to Docker #30

merged 2 commits into from
Nov 5, 2021

Conversation

riita10069
Copy link
Member

@riita10069 riita10069 commented Sep 30, 2021 •
edited
Loading

Fixes #29

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 30, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @riita10069!

It looks like this is your first PR to kubernetes-sigs/kube-scheduler-simulator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kube-scheduler-simulator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2021
sanposhiho
sanposhiho reviewed Oct 1, 2021
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

README.md Outdated
@@ -53,6 +53,9 @@ make docker_build_and_up

Then, you can access the simulator with http://localhost:3000

Note: 4GB of memory should be allocated to Docker.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't exactly figured out the cause. This problem may occur only in docker for mac. (I mean it may not always require 4GB momory)
So, lMO it is better to change the wording to something a little more ambiguous.

like:

Note: Insufficient memory allocation sometimes causes problems in building the image.
Please allocate enough memory in that case.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4GB sounds like a lot. What is consuming that? the frontend or the backend?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing to build an Image.

I had a problem with 2GB memory allocation.
With 4GB, it did not happen.

sanposhiho
sanposhiho reviewed Oct 1, 2021
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riita10069 can you change this PR description to like Fixes #29

Because GitHub automatically close the issue after this PR is merged
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

sanposhiho
sanposhiho approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been investigating for a while, but I couldn't find any solution to this issue.

It seems that there are cases where something uses a lot of memory during the build process of nodejs. In some cases, such problems can be solved by introducing NODE_OPTIONS="–-max_old_space_size=XXX", but it did not solve our problem.

So, I'd like to accept this change -- The simplest solution is to allocate more memory.
And, when we provide the image for the simulator (#19), users will not have to build the image themselves. So fewer users will face this problem.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2021
@alculquicondor
Copy link

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, riita10069, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit eb95091 into kubernetes-sigs:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho approved these changes

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make docker_build_and_up failed
4 participants
@riita10069 @k8s-ci-robot @alculquicondor @sanposhiho