Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce the places where users have to register for using custom plugins #332

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

sanposhiho
Copy link
Member

What type of PR is this?

/area simulator
/kind bug

What this PR does / why we need it:

Before this PR, users had to register their custom plugin names in registeredOutOfTreeMultiPointName.
This is undocumented and led to this kind of issue: #311.

This PR eliminates the need to register registeredOutOfTreeMultiPointName in the first place, rather than documenting the existence of registeredOutOfTreeMultiPointName.

Which issue(s) this PR fixes:

Fixes #311

Special notes for your reviewer:

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added area/simulator Issues or PRs related to the simulator. kind/bug Categorizes issue or PR as related to a bug. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Feb 3, 2024
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Feb 3, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 3, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 3, 2024
@sanposhiho
Copy link
Member Author

/retest
/assign @utam0k

@utam0k
Copy link
Member

utam0k commented Mar 6, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2024
@utam0k
Copy link
Member

utam0k commented Mar 9, 2024

It seems the linter job failed. Can you check it?

make[1]: Entering directory '/home/prow/go/src/sigs.k8s.io/kube-scheduler-simulator/simulator'
golangci-lint run --timeout 90m ./...
scheduler/config/plugin.go:10: File is not `gofumpt`-ed (gofumpt)
var (
	outOfTreeRegistries = runtime.Registry{
		// TODO(user): add your plugins registries here.
	}
)
make[1]: *** [Makefile:8: lint] Error 1

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2024
@sanposhiho
Copy link
Member Author

@utam0k Please revisit here when have chance.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2024
@sanposhiho
Copy link
Member Author

Rebased.

@sanposhiho
Copy link
Member Author

/priority next-release

@k8s-ci-robot k8s-ci-robot added the priority/next-release Issues or PRs related to features should be implemented in time for the next release. label Mar 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho, utam0k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@utam0k
Copy link
Member

utam0k commented Mar 29, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit c5d91e0 into master Mar 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/simulator Issues or PRs related to the simulator. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/next-release Issues or PRs related to features should be implemented in time for the next release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with the integration of custom plugins into the simulator
3 participants