Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go.mod go version to 1.20 #12

Conversation

gonzaloserrano
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

I tried running guest/ tests with go 1.20.x and got

internal/imports/mem.go:24:24: unsafe.StringData requires go1.20 or later (-lang was set to go1.19; check go.mod)

Then I downgraded to go 1.19 (via brew) and got:

# sigs.k8s.io/kube-scheduler-wasm-extension/guest/internal/imports
internal/imports/mem.go:24:31: undefined: unsafe.StringData

So since unsafe.StringData is from go 1.20 I guess the guest go.mod should specify go 1.20? Most of the repo versions, and kubernetes/kubernetes also, have go 1.20 in their go.mod.

Which issue(s) this PR fixes:

n/a

Special notes for your reviewer:

n/a

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gonzaloserrano
Once this PR has been reviewed and has the lgtm label, please assign kerthcet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 24, 2023
@codefromthecrypt
Copy link
Contributor

There are no tests in the guest module, so I think the impact of this is lower.

We are intentionally leaving the guest (tinygo) as 1.19 until TinyGo 0.28 which supports 1.20 is out (very soon). We should probably add a comment to the go.mod that this is for tinygo.

@kerthcet
Copy link
Contributor

/hold
Feel free to close this or hold until tinygo releases v0.28.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants