Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: adds basic setup #30

Merged
merged 1 commit into from
Jun 7, 2023
Merged

ci: adds basic setup #30

merged 1 commit into from
Jun 7, 2023

Conversation

codefromthecrypt
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This sets up basic CI with a couple notable targets:

  • make check: runs various linters and formatters, and ensures projects build.
  • make test-scheduler: runs scheduler-based unit and e2e tests.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Later, we can make tests that run in tinygo for the guest, but as that's tricky I left things here for now.

Does this PR introduce a user-facing change?

NONE

What are the benchmark results of this change?

N/A

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 6, 2023
@codefromthecrypt codefromthecrypt mentioned this pull request Jun 6, 2023
Closed
3 tasks
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 6, 2023
@codefromthecrypt
Copy link
Contributor Author

rebased. I'm not sure if actions are disabled on this repo, but most of the change only helps if they are.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 6, 2023
@codefromthecrypt
Copy link
Contributor Author

rebased. main thing left in here is lint fix, fix of tinygo go.mod, and basic CI plumbing

anuraaga
anuraaga reviewed Jun 7, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
anuraaga
anuraaga reviewed Jun 7, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
anuraaga
anuraaga approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.github/workflows/commit.yaml Outdated
steps:
- uses: actions/checkout@v3

- uses: actions/setup-go@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like using v4 elsewhere but not here, if it's because of the default cache behavior, maybe can use v4 and cache: false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accident

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well you are right ;) missing comment which should be there with the false

Makefile Show resolved Hide resolved
@anuraaga
ci: adds basic setup
b8b2422 
This sets up basic CI with a couple notable targets:

* `make check`: runs various linters and formatters, and ensures
  projects build.
* `make test-scheduler`: runs scheduler-based unit and e2e tests.

Later, we can make tests that run in tinygo for the guest, but as that's
tricky I left things here for now.

Signed-off-by: Adrian Cole <adrian@tetrate.io>
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
@codefromthecrypt
Copy link
Contributor Author

thanks @anuraaga I wove in the feedback and preemptively squashed as usually asked to and doing that loses approvals.

kerthcet
kerthcet reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
approve

Let's see how it works.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2023
@codefromthecrypt codefromthecrypt mentioned this pull request Jun 7, 2023
Merged
@kerthcet
Copy link
Contributor

kerthcet commented Jun 7, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anuraaga, codefromthecrypt, kerthcet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit bbdfebb into kubernetes-sigs:main Jun 7, 2023
2 checks passed
@codefromthecrypt
Copy link
Contributor Author

Thanks for the help getting this together @anuraaga and thanks for being open to trying non-standard CI @kerthcet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerthcet kerthcet kerthcet left review comments

@anuraaga anuraaga anuraaga approved these changes

Assignees

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codefromthecrypt @kerthcet @k8s-ci-robot @anuraaga