-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
have a label tide/merge-method-squash in all PRs #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this limit the message to only the title of PR? GitHub has this feature now, and it is a lot nicer that a list of "broke, fixed, fuzz" etc.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codefromthecrypt, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It also has the commits like f801a88 |
Well, seems we need to have the tide/merge-method-squash label anyway then to let the bot squash-merge the PR. 😓 |
@sanposhiho I'm not familiar with the bot but my guess would be you need to add |
My concern is independent commits will also be squashed. Prefer to label that manually. |
if we do well one PR is small enough that independent commits aren't needed. how about it? |
Have a chat with @codefromthecrypt, let's keep as it is now. /close |
@sanposhiho: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
have a label
tide/merge-method-squash
in all PRs via PR template.Instead of asking squash for authors, we can ask the bot to do squash merge.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
What are the benchmark results of this change?