-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes guest index back to UID #42
Changes guest index back to UID #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks!
// TODO: The guest should always implement PreFilter, so it can know to | ||
// reset state when the same pod has been re-scheduled due to an error. We |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/hold |
@codefromthecrypt can you check the CI fail? I'm not sure how go.mod is related to this PR's change though. |
go.mod was related. I should have run |
Signed-off-by: Adrian Cole <adrian@tetrate.io>
71c9cf4
to
e66dbad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/unhold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codefromthecrypt, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In #39 we switched from using the pod UID to the pointer due to a problem identifying of how to handle the same pod being rescheduled sequentially on error. @sanposhiho found that since
PreFilter
must always be called, we can reset state always on that hook. A later change can instruct the guest to always dump any cache onPreFilter
even if the UID is the same as last time. Meanwhile, this change mechanically switches the host-side index back to the pod UID.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
What are the benchmark results of this change?