Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s versions from x.26.2 to x.27.3 #49

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

codefromthecrypt
Copy link
Contributor

@codefromthecrypt codefromthecrypt commented Jun 26, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Before, we were using inconsistent versions of k8s (mostly x.26.2, but some x.26.1). Also, we used an arbitrary commit from master to generate proto sources. This updates all k8s dependencies to x.27.3 and uses the 1.27.3 commit to generate protos.

This also uses a newer version of the source generation plugin.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

What are the benchmark results of this change?

goos: darwin
goarch: arm64
pkg: sigs.k8s.io/kube-scheduler-wasm-extension/internal/e2e
                                                        │ before.txt  │             after.txt             │
                                                        │   sec/op    │   sec/op     vs base              │
PluginPreFilter/noop-wat/params:_small-12                 133.7n ± 1%   133.2n ± 0%  -0.41% (p=0.006 n=6)
PluginPreFilter/noop-wat/params:_real-12                  134.3n ± 1%   133.2n ± 1%       ~ (p=0.056 n=6)
PluginPreFilter/noop/params:_small-12                     157.6n ± 1%   156.3n ± 0%  -0.82% (p=0.002 n=6)
PluginPreFilter/noop/params:_real-12                      157.2n ± 1%   157.0n ± 0%       ~ (p=0.106 n=6)
PluginPreFilter/test/params:_small-12                     3.835µ ± 0%   3.954µ ± 0%  +3.10% (p=0.002 n=6)
PluginPreFilter/test/params:_real-12                      45.02µ ± 1%   46.03µ ± 1%  +2.23% (p=0.002 n=6)
PluginFilter/noop-wat/params:_small-12                    269.6n ± 4%   263.5n ± 0%  -2.24% (p=0.004 n=6)
PluginFilter/noop-wat/params:_real-12                     268.1n ± 1%   263.9n ± 0%  -1.53% (p=0.002 n=6)
PluginFilter/noop/params:_small-12                        323.4n ± 0%   319.6n ± 0%  -1.14% (p=0.002 n=6)
PluginFilter/noop/params:_real-12                         324.1n ± 0%   319.5n ± 0%  -1.42% (p=0.002 n=6)
PluginFilter/test/params:_small-12                        7.104µ ± 0%   7.173µ ± 1%  +0.98% (p=0.028 n=6)
PluginFilter/test/params:_real-12                         108.7µ ± 1%   109.0µ ± 0%       ~ (p=0.180 n=6)
PluginScore/noop-wat/params:_small-12                     267.4n ± 0%   265.7n ± 0%  -0.65% (p=0.002 n=6)
PluginScore/noop-wat/params:_real-12                      267.8n ± 0%   264.4n ± 1%  -1.25% (p=0.002 n=6)
PluginScore/noop/params:_small-12                         372.1n ± 0%   367.1n ± 1%  -1.34% (p=0.002 n=6)
PluginScore/noop/params:_real-12                          339.3n ± 0%   335.1n ± 0%  -1.25% (p=0.002 n=6)
PluginScore/test/params:_small-12                         4.083µ ± 0%   4.199µ ± 1%  +2.84% (p=0.002 n=6)
PluginScore/test/params:_real-12                          45.63µ ± 1%   46.60µ ± 1%  +2.12% (p=0.002 n=6)
PluginPrefilterFilterAndScore/noop-wat/params:_small-12   399.2n ± 0%   392.7n ± 1%  -1.63% (p=0.002 n=6)
PluginPrefilterFilterAndScore/noop-wat/params:_real-12    399.8n ± 0%   394.5n ± 0%  -1.31% (p=0.002 n=6)
PluginPrefilterFilterAndScore/noop/params:_small-12       555.2n ± 0%   556.5n ± 2%       ~ (p=0.937 n=6)
PluginPrefilterFilterAndScore/noop/params:_real-12        597.4n ± 1%   599.2n ± 1%       ~ (p=0.589 n=6)
PluginPrefilterFilterAndScore/test/params:_small-12       7.545µ ± 1%   7.657µ ± 0%  +1.49% (p=0.002 n=6)
PluginPrefilterFilterAndScore/test/params:_real-12        110.7µ ± 2%   113.0µ ± 1%  +2.03% (p=0.009 n=6)
geomean                                                   1.157µ        1.157µ       -0.03%

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 26, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 26, 2023
@codefromthecrypt
Copy link
Contributor Author

wait I accidentally ran bench before from an old commit of main

Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codefromthecrypt
Copy link
Contributor Author

ok using latest main, performance is 1-2.x% slower, but this update is about version coherence not performance.

@@ -2,4 +2,5 @@ staging/src/k8s.io/api/core/v1/generated.proto
staging/src/k8s.io/apimachinery/pkg/api/resource/generated.proto
staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/generated.proto
staging/src/k8s.io/apimachinery/pkg/runtime/generated.proto
staging/src/k8s.io/apimachinery/pkg/runtime/schema/generated.proto
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably messed up when I edited this file last, because this should have been there despite the actual source not being used at runtime (it is required at generation time)

Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codefromthecrypt, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [codefromthecrypt,sanposhiho]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 33e3928 into kubernetes-sigs:main Jun 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants