-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8s versions from x.26.2 to x.27.3 #49
Conversation
wait I accidentally ran bench before from an old commit of main |
Signed-off-by: Adrian Cole <adrian@tetrate.io>
e91bda4
to
1c7be92
Compare
ok using latest main, performance is 1-2.x% slower, but this update is about version coherence not performance. |
@@ -2,4 +2,5 @@ staging/src/k8s.io/api/core/v1/generated.proto | |||
staging/src/k8s.io/apimachinery/pkg/api/resource/generated.proto | |||
staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/generated.proto | |||
staging/src/k8s.io/apimachinery/pkg/runtime/generated.proto | |||
staging/src/k8s.io/apimachinery/pkg/runtime/schema/generated.proto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably messed up when I edited this file last, because this should have been there despite the actual source not being used at runtime (it is required at generation time)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codefromthecrypt, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Before, we were using inconsistent versions of k8s (mostly x.26.2, but some x.26.1). Also, we used an arbitrary commit from master to generate proto sources. This updates all k8s dependencies to x.27.3 and uses the 1.27.3 commit to generate protos.
This also uses a newer version of the source generation plugin.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
What are the benchmark results of this change?