Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update k8s to 1.25 and go to 1.19 #238

Merged
merged 6 commits into from Sep 7, 2022
Merged

update k8s to 1.25 and go to 1.19 #238

merged 6 commits into from Sep 7, 2022

Conversation

everettraven
Copy link
Contributor

What this PR does / why we need it:
Updates Kubernetes dependencies to 1.25 and Go to 1.19 to provide support for using kubebuilder-declarative-pattern with k8s 1.25

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation:

@everettraven
update k8s to 1.25 and go to 1.19
724b547 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Aug 29, 2022
@everettraven
update actions to use Go 1.19
1da6ed7 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven
update goimports
49b9167 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven
update goimports again
27dfd7f 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven everettraven mentioned this pull request Aug 31, 2022
Closed
13 tasks
@everettraven
update controller-runtime to v0.13.0
2e0cbd3 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven everettraven marked this pull request as ready for review September 6, 2022 14:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2022
@everettraven
Copy link
Contributor Author

@atoato88 this PR should now be in a good state to review. Please let me know if there is anything else needed, thanks!

@everettraven
update example go.mod
50c922c 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 6, 2022
@atoato88
Copy link
Contributor

atoato88 commented Sep 6, 2022

Thank you for updating!
It looks good!
And CI tests have passed too.

atoato88
atoato88 reviewed Sep 6, 2022
View reviewed changes
Copy link
Contributor

@atoato88 atoato88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments about doc.go.
I think it's something format update for documentation, but please let me know a background about this update.

doc.go
@@ -18,7 +18,7 @@ limitations under the License.
// declarative Kubernetes operators to manage the lifecycle of a
// deployment.
//
// Getting Started
// # Getting Started
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it paragraph markup on markdown format?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to do with gofmt updates related to bumping the Go version to Go 1.19.

If you take a look at the Headings section of this documentation https://tip.golang.org/doc/comment you can see that as of Go 1.19 the new heading format is similar to Markdown and uses the # prefix:

The # syntax was added in Go 1.19. Before Go 1.19, headings were identified implicitly by single-line paragraphs satisfying certain conditions, most notably the lack of any terminating punctuation.

Gofmt reformats lines treated as implicit headings by earlier versions of Go to use # headings instead. If the reformatting is not appropriate—that is, if the line was not meant to be a heading—the easiest way to make it a paragraph is to introduce terminating punctuation such as a period or colon, or to break it into two lines.

I hope this helps!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for detailed and helpful comment.
I understood that. 👍

pkg/patterns/addon/doc.go
@@ -26,7 +26,7 @@ implements the addonsv1alpha1.CommonObject interface. The object represents the
to deploy an instance of a specific Addon in the cluster. This pattern manages a
Kubernetes deployment for the specific addon based on the Addon Object.

Writing an Addon Operator
# Writing an Addon Operator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: #238 (comment)

@atoato88
Copy link
Contributor

atoato88 commented Sep 7, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit e0605f0 into kubernetes-sigs:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoato88 atoato88 atoato88 left review comments

@estroz estroz Awaiting requested review from estroz

@justinsb justinsb Awaiting requested review from justinsb

@monopole monopole Awaiting requested review from monopole

Assignees

@atoato88 atoato88

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@everettraven @k8s-ci-robot @atoato88