Close the WatchStart before starting the watch. It was anyways closed… #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/XS
|
/assign @justinsb |
atoato88
reviewed
Feb 5, 2024
| @@ -35,8 +36,17 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/log" | |||
| ) | |||
|
|
|||
| // WatchDelay is the time between a Watch being dropped and attempting to resume it | |||
| const WatchDelay = 30 * time.Second | |||
| const ( | |||
There was a problem hiding this comment.
There are two const sections at here.
What is the reason to be splited to?
|
Current title of this PR doesn't indicate the current contents, I think. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: barney-s The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up Watch() sometimes results in Watch() being a blocking call. Add a cancellable context that times out sooner when there is no activity in the Apply() path. Otherwise it timesout in 5mins. Cancellable context is better than watch options.Timeout since watch timeout happens even if there is activity on the watch channel.
What this PR does / why we need it:
In BeforeApply watch setup case, it blocks the Apply loop if the API server doesnt have any watch events for the first object being applied.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation: