Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump controller-runtime to 0.17 / kube to 1.29 #380

Merged
merged 3 commits into from Mar 20, 2024
Merged

Bump controller-runtime to 0.17 / kube to 1.29 #380

merged 3 commits into from Mar 20, 2024

Conversation

justinsb
Copy link
Contributor

  • chore: Update to controller-runtime 0.17 / kube 1.29
  • deprecation: Use NewDynamicRESTMapper instead of NewDiscoveryRESTMapper

@justinsb
chore: Update to controller-runtime 0.17 / kube 1.29
fa951b6 
We need kubectl 1.29.1 due to a regression in OpenAPIGetter in kubectl
1.29.0, fixed in 1.29.1
@justinsb
deprecation: Use NewDynamicRESTMapper instead of NewDiscoveryRESTMapper
de1de0f 
NewDiscoveryRESTMapper has been removed from the latest
controller-runtime.

NewDynamicRESTMapper is preferred, and is available in older versions
of controller-runtime also, so prefer that in all controller-runtime
versions.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 26, 2024
@justinsb justinsb changed the title bump controller runtime WIP: Bump controller-runtime to 0.17 / kube to 1.29 Feb 26, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
@tomasaschan
Copy link
Member

Let me know if I can help speed this along somehow!

@atoato88
Copy link
Contributor

This PR is related with the content of #379.
I think #379 can be closed if this PR is merged.

atoato88
atoato88 reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@atoato88 atoato88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this PR is WIP, but I left just one comment.

go.mod
go 1.20
go 1.21

toolchain go1.22.0
Copy link
Contributor

@atoato88 atoato88 Feb 28, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, we should update the files for GitHub Actions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right - I just pushed that and tests are looking much happier!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I just saw that @tomasaschan proposed a better version of the change in justinsb#1 , so using that one

@tomasaschan tomasaschan mentioned this pull request Mar 6, 2024
Merged
@atoato88
Copy link
Contributor

atoato88 commented Mar 7, 2024

@justinsb
Ping, how about the current state of this?

@justinsb justinsb changed the title WIP: Bump controller-runtime to 0.17 / kube to 1.29 Bump controller-runtime to 0.17 / kube to 1.29 Mar 17, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2024
@justinsb
Copy link
Contributor Author

Removed WIP, and I also think we should consider expanding ownership of this repo, perhaps starting with @tomasaschan . Sometimes I get pulled into different things and things fall off my plate - sorry for the delays here!

@tomasaschan
Copy link
Member

/lgtm

(but I suspect it won't matter yet...)

@k8s-ci-robot
Copy link
Contributor

@tomasaschan: changing LGTM is restricted to collaborators

In response to this:

/lgtm

(but I suspect it won't matter yet...)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@atoato88
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit b560427 into kubernetes-sigs:master Mar 20, 2024
6 checks passed
@atoato88
Copy link
Contributor

I agree with expanding ownership. 👍

@atoato88 atoato88 mentioned this pull request Mar 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoato88 atoato88 atoato88 left review comments

Assignees

@atoato88 atoato88

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinsb @k8s-ci-robot @tomasaschan @atoato88