Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing spaces in generated README.md #3812

Closed
bzub opened this issue Mar 6, 2024 · 4 comments · Fixed by #3813
Closed

Trailing spaces in generated README.md #3812

bzub opened this issue Mar 6, 2024 · 4 comments · Fixed by #3813
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@bzub
Copy link
Member

bzub commented Mar 6, 2024

What broke? What's expected?

After running kubebuilder init some lines in the README.md contain trailing whitespace.

Reproducing this issue

Run kubebuilder init.

KubeBuilder (CLI) Version

3.14.0

PROJECT version

3

Plugin versions

go.kubebuilder.io/v4

Other versions

No response

Extra Labels

No response

@bzub bzub added the kind/bug Categorizes issue or PR as related to a bug. label Mar 6, 2024
@mateusoliveira43
Copy link
Contributor

Would be interesting top consider adding https://editorconfig.org/ to the project to avoid this in the future?

Example configuration we use https://github.com/migtools/oadp-non-admin/blob/master/.editorconfig

@camilamacedo86
Copy link
Member

Hi @mateusoliveira43

We can sort it out using shell script. Note that we try as much as possible not add dependencies with third-part. Use third-party solutions usually increase the effort to keep things maintained, it ofen make hard for contributors as well since to do something they might to skill up with so many other solutions.

Ideally, we should when we run make generate remove ALL trailing spaces of the docs for example.
Feel free to check it out if you wish and proposed a solution

@camilamacedo86
Copy link
Member

@bzub @mateusoliveira43

See now we can solve it across the whole project when we run make generate
Also, now we are checking of the spaces so we will not get merged stuff with trailing spaces.

See: #3826

@mateusoliveira43
Copy link
Contributor

Nice solution @camilamacedo86 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants