-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log info fails #126
base: main
Are you sure you want to change the base?
Log info fails #126
Conversation
Ping @alexzielenski |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
in case you wanted to remove the name validation, otherwise use /remove-hold
(or /hold cancel
?)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, omerap12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Hey @alexzielenski . |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds more information when fails.
For example, for the following manifest:
The error would look like:
Which issue(s) this PR fixes:
Fixes #94
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: