-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate name before validation #130
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ewon78 <zhouguanginfo@jd.com>
|
Welcome @ewon78! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ewon78 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/easycla |
What type of PR is this?
/kind bug
What this PR does / why we need it:
generate name for the resource before validation if it has no name but generatedName is set.
Which issue(s) this PR fixes:
Fixes #121
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: