Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add github workflow and docker examples #59

Merged
merged 6 commits into from
Jul 31, 2023

Conversation

eyarz
Copy link
Contributor

@eyarz eyarz commented Jul 5, 2023

Because kubectl-validate doesn't have an official docker image (yet), this is a simple implantation example of using kubectl-validate with github action workflow and docker file.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2023
@eyarz eyarz mentioned this pull request Jul 5, 2023
Copy link
Contributor

@alexzielenski alexzielenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate you adding this? Has this workflow been tested anywhere?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@eyarz
Copy link
Contributor Author

eyarz commented Jul 6, 2023

Really appreciate you adding this? Has this workflow been tested anywhere?

of course! I added a link in the PR description:
https://github.com/eyarz/kubectl-validate-playground/actions

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Eyar Zilberman and others added 3 commits July 12, 2023 10:04
Co-authored-by: Antoine Pelisse <apelisse@gmail.com>
@eyarz eyarz requested a review from apelisse July 12, 2023 07:22
Copy link
Contributor

@apelisse apelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@alexzielenski do you want to approve?

- name: Setup go
uses: actions/setup-go@v4
with:
go-version: '1.20'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is inferred from go.mod if missing, we could get rid of this. just FYI.

README.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2023
@eyarz
Copy link
Contributor Author

eyarz commented Jul 16, 2023

@alexzielenski @apelisse
not sure so I'm verifying :)
do you need any code changes from my side to get this PR merged?

@alexzielenski
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexzielenski, eyarz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2023
@eyarz
Copy link
Contributor Author

eyarz commented Jul 27, 2023

@alexzielenski @apelisse
it looks like this PR failed CI on an unrelated issue to the code changes that I submitted.
is there something I do to help this PR get merged? I don't want this PR drift to much away from main...

@apelisse
Copy link
Contributor

I'm re-running the job, hopefully it will work, thanks for bringing this to my attention!

@k8s-ci-robot k8s-ci-robot merged commit 11df32a into kubernetes-sigs:main Jul 31, 2023
5 checks passed
@apelisse
Copy link
Contributor

Well, there you go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants