-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add github workflow and docker examples #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate you adding this? Has this workflow been tested anywhere?
of course! I added a link in the PR description: |
Co-authored-by: Antoine Pelisse <apelisse@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
@alexzielenski do you want to approve?
- name: Setup go | ||
uses: actions/setup-go@v4 | ||
with: | ||
go-version: '1.20' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is inferred from go.mod
if missing, we could get rid of this. just FYI.
@alexzielenski @apelisse |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, eyarz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alexzielenski @apelisse |
I'm re-running the job, hopefully it will work, thanks for bringing this to my attention! |
Well, there you go! |
Because kubectl-validate doesn't have an official docker image (yet), this is a simple implantation example of using kubectl-validate with github action workflow and docker file.