Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate patches for native type schema deficiencies #60

Merged
merged 6 commits into from
Jul 28, 2023

Conversation

alexzielenski
Copy link
Contributor

@alexzielenski alexzielenski commented Jul 5, 2023

Adds some code to the native schema downloader that also generates patches to workaround known deficiencies in native schema.

Fixes #60

Currently included patches:

  1. Allow empty byte format strings
  2. Allow empty date-time format strings
  3. Remove default: {} where it does not make sense

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexzielenski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 5, 2023
@alexzielenski alexzielenski merged commit 4435d7d into kubernetes-sigs:main Jul 28, 2023
4 of 5 checks passed
@richardvflux
Copy link

I just built the docker image for this two hours ago and now hit this bug and notice you fixed it an hour ago 😂 Nice work!

@eddycharly
Copy link
Contributor

Awesome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants