-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exit code on failure #63
Conversation
/lgtm since @apelisse is out and we need this |
@alexzielenski: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
main.go
Outdated
@@ -10,6 +9,6 @@ import ( | |||
func main() { | |||
rootCmd := cmd.NewRootCommand() | |||
if err := rootCmd.Execute(); err != nil { | |||
fmt.Fprintln(os.Stderr, err.Error()) | |||
os.Exit(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you'll have to live with this. Do you want to somehow use a separate code for validation errors and other errors (i.e. can't load file?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added separate exit codes for the different error paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cute!
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, apelisse The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
they should be respected and logged to the user
f810192
to
d31a8fd
Compare
/hold cancel there were a few error messages I wanted to improve. Also saw a bug that composite client silently ignores errors. |
/lgtm |
/hold cancel |
Continuation of #62 which seems to have stalled. We need this change asap.
/cc @apelisse