-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added warning for recursive schema #86
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: swastik959 <Sswastik959@gmail.com>
Welcome @swastik959! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: swastik959 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: swastik959 <Sswastik959@gmail.com>
@alexzielenski , @apelisse . can you please review this pr ? |
Thanks! Could you add a test? |
@alexzielenski I don't get what you mean by tests here as schema-visitor does not have a unit test associated with it ? |
Could add an e2e/integration test that asserts the expected log output, and shows that the files using recursive schema are skipped. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
added warning for recursive schema
closes #18