This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
upgrade github.com/evanphx/json-patch to v4.12.0 #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix partial negative indice support in json patch
k8s-ci-robot
added
cncf-cla: yes
|
Seems like the test failed due to some irrevelant issue.. @hectorj2f Mind rerun the test? Thanks. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimmidyson, zqzten The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR upgrades github.com/evanphx/json-patch to v4.12.0 which includes fix evanphx/json-patch#146 in order to fix a panic when KubeFed controller reconcile a federated object with negative array index in its overrides.
This upgrade also enables full support on negative array indice in overrides.
Which issue(s) this PR fixes:
Fixes #1466