Skip to content

Commit

Permalink
add local-path-provosioner helper image def (#5817)
Browse files Browse the repository at this point in the history
  • Loading branch information
@MikeGoltsov
MikeGoltsov committed Apr 8, 2020
1 parent 0c51352 commit 45a177e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
2 changes: 2 additions & 0 deletions inventory/sample/group_vars/k8s-cluster/addons.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ local_path_provisioner_enabled: false
# local_path_provisioner_debug: false
# local_path_provisioner_image_repo: "rancher/local-path-provisioner"
# local_path_provisioner_image_tag: "v0.0.2"
# local_path_provisioner_helper_image_repo: "busybox"
# local_path_provisioner_helper_image_tag: "latest"

# Local volume provisioner deployment
local_volume_provisioner_enabled: false
Expand Down
1 change: 1 addition & 0 deletions roles/kubernetes-apps/external_provisioner/local_path_provisioner/defaults/main.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ local_path_provisioner_reclaim_policy: Delete
local_path_provisioner_claim_root: /opt/local-path-provisioner/
local_path_provisioner_is_default_storageclass: "true"
local_path_provisioner_debug: false
local_path_provisioner_helper_image_tag: "latest"
4 changes: 4 additions & 0 deletions ...xternal_provisioner/local_path_provisioner/templates/local-path-storage-deployment.yml.j2
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ spec:
- /etc/config/config.json
{% if local_path_provisioner_debug|default(false) %}
- --debug
{% endif %}
{{ if local_path_provisioner_helper_image is defined }}
- --helper-image
- {{local_path_provisioner_helper_image_repo}}:{{local_path_provisioner_helper_image_tag}}
{% endif %}
volumeMounts:
- name: config-volume
Expand Down

2 comments on commit 45a177e

@madianas
Copy link

@madianas madianas commented on 45a177e Apr 20, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Would you happen to know why am I getting the following error?

2020-04-20T21:05:44.998210011Z Incorrect Usage: flag provided but not defined: -helper-image
2020-04-20T21:05:44.998285867Z 
2020-04-20T21:05:44.998361886Z NAME:
2020-04-20T21:05:44.998375539Z    local-path-provisioner start - 
2020-04-20T21:05:44.99837957Z 
2020-04-20T21:05:44.998383154Z USAGE:
2020-04-20T21:05:44.998474724Z    local-path-provisioner start [command options] [arguments...]
2020-04-20T21:05:44.99848489Z 
2020-04-20T21:05:44.998488526Z OPTIONS:
2020-04-20T21:05:44.99849213Z    --config value            Required. Provisioner configuration file.
2020-04-20T21:05:44.998495803Z    --provisioner-name value  Required. Specify Provisioner name. (default: "rancher.io/local-path") [$PROVISIONER_NAME]
2020-04-20T21:05:44.998500763Z    --namespace value         Required. The namespace that Provisioner is running in (default: "local-path-storage") [$NAMESPACE]
2020-04-20T21:05:44.99850463Z    
2020-04-20T21:05:44.998823432Z time="2020-04-20T21:05:44Z" level=fatal msg="Critical error: flag provided but not defined: -helper-image"

These are my settings

# Rancher Local Path Provisioner
local_path_provisioner_enabled: true
local_path_provisioner_namespace: "local-path-storage"
local_path_provisioner_storage_class: "local-path"
local_path_provisioner_reclaim_policy: Retain
local_path_provisioner_claim_root: /var/local-path-provisioner/
local_path_provisioner_debug: false
local_path_provisioner_image_repo: "rancher/local-path-provisioner"
local_path_provisioner_image_tag: "v0.0.2"
local_path_provisioner_helper_image_repo: "busybox"
local_path_provisioner_helper_image_tag: "latest"

Let me know if you need more details

@michalskalski
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madianas you need to use local path provisioner at least in version 0.0.3, please take a look here #6437

Please sign in to comment.