Skip to content

Commit

Permalink
Remove deprecated crio_pids_limits
Browse files Browse the repository at this point in the history
As per cri-o/cri-o#5831, option is now
deprecated.
  • Loading branch information
j4m3s-s committed May 17, 2023
1 parent a257e61 commit 9d0ae43
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 21 deletions.
14 changes: 0 additions & 14 deletions docs/cri-o.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,21 +40,7 @@ crio_registries:
insecure: false
```

## Note about pids_limit

For heavily mult-threaded workloads like databases, the default of 1024 for pids-limit is too low.
This parameter controls not just the number of processes but also the amount of threads
(since a thread is technically a process with shared memory). See [cri-o#1921]

In order to increase the default `pids_limit` for cri-o based deployments you need to set the `crio_pids_limit`
for your `k8s_cluster` ansible group or per node depending on the use case.

```yaml
crio_pids_limit: 4096
```

[CRI-O]: https://cri-o.io/
[cri-o#1921]: https://github.com/cri-o/cri-o/issues/1921

## Note about user namespaces

Expand Down
4 changes: 0 additions & 4 deletions roles/container-engine/cri-o/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,6 @@ youki_runtime:
crio_download_base: "download.opensuse.org/repositories/devel:kubic:libcontainers:stable"
crio_download_crio: "http://{{ crio_download_base }}:/cri-o:/"

# Configure the cri-o pids limit, increase this for heavily multi-threaded workloads
# see https://github.com/cri-o/cri-o/issues/1921
crio_pids_limit: 1024

# Reserve 16M uids and gids for user namespaces (256 pods * 65536 uids/gids)
# at the end of the uid/gid space
crio_remap_enable: false
Expand Down
3 changes: 0 additions & 3 deletions roles/container-engine/cri-o/templates/crio.conf.j2
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,6 @@ default_mounts = [
#
#default_mounts_file = ""

# Maximum number of processes allowed in a container.
pids_limit = {{ crio_pids_limit }}

# Maximum sized allowed for the container log file. Negative numbers indicate
# that no size limit is imposed. If it is positive, it must be >= 8192 to
# match/exceed conmon's read buffer. The file is truncated and re-opened so the
Expand Down

0 comments on commit 9d0ae43

Please sign in to comment.