Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delegate_to can't be combined with include_tasks anymore on current Ansible master #3815

Closed
jqueuniet opened this issue Dec 4, 2018 · 4 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@jqueuniet
Copy link
Contributor

jqueuniet commented Dec 4, 2018

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Environment:

  • OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):
Linux 4.19.4-arch1-1-ARCH x86_64
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
ID_LIKE=archlinux
ANSI_COLOR="0;36"
HOME_URL="https://www.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://bugs.archlinux.org/"
  • Version of Ansible (ansible --version):
ansible 2.8.0.dev0
  config file = /[...]/ansible.cfg
  configured module search path = ['/[...]/3d/kubespray/library']
  ansible python module location = /usr/lib/python3.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 3.7.1 (default, Oct 22 2018, 10:41:28) [GCC 8.2.1 20180831]

Kubespray version (commit) (git rev-parse --short HEAD): 1911fe5

Output of ansible run:

ERROR! 'delegate_to' is not a valid attribute for a TaskInclude

The error appears to have been in '/[...]/3d/kubespray/roles/network_plugin/calico/tasks/main.yml': line 6, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:


- include_tasks: upgrade.yml
  ^ here

Anything else do we need to know:

Following ansible/ansible#46177, currently on ansible/devel and slated for Ansible 2.8, invalid keywords that used to silently fail or behave in some other way with includes now crash with a AnsibleParserError.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 11, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 11, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xunholy added a commit to raspbernetes/k8s-cluster-installation that referenced this issue Jan 30, 2021
* enable cilium CNI option

Signed-off-by: Ryan Holt <ryan@ryanholt.net>

* fix some variables

Signed-off-by: Ryan Holt <ryan@ryanholt.net>

* change variable name

Signed-off-by: Ryan Holt <ryan@ryanholt.net>

* set permissions on manifests folder and ignore curl warning

Signed-off-by: Ryan Holt <ryan@ryanholt.net>

* should have been inside args

Signed-off-by: Ryan Holt <ryan@ryanholt.net>

* add some creates pieces to commands

* add some creates pieces to commands

Signed-off-by: Ryan Holt <ryan@ryanholt.net>

* args needed to nest creates

Signed-off-by: Ryan Holt <ryan@ryanholt.net>

* add another pipefail option

* Updating variable role prefix and addressing some feedback

Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com>

* fix ansible lint issues

Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com>

* update helm values to be from a j2 template

Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com>

* Testing cilium on Kubic

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Add multi-arch envoyproxy/envoy

Opt to use newer offical image rather then 3rd party source.

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Add quotes for endpoint routes

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Type check on inventory side

Need to read more about this

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Revised Values

* Moved masquerade into bpf block
* Trying tunnel
* Updated comments

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Disable tunnel

* Begin adding helm ansible galaxy module

Cilium is incomplete.

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Revise cilium role to further use k8s modules

* Added check for kuberouter

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Set hostname to inventory hostname if not already set.

This will prevent haproxy from failing.

HA Proxy Daemon will fail to start if the hostnames are all the same.

```
fatal: [node-03]: FAILED! => changed=false
  msg: |-
    Unable to restart service haproxy: Job for haproxy.service failed because the control process exited with error code.
    See "systemctl status haproxy.service" and "journalctl -xe" for details.
```

Instead of depending on the user setting the hostnames in cloudinit or
alike instead add a check.

This may have issues with SUSE. See
(ansible/ansible#42726)

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Add default pod subnet

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Try adding quotes on version.

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* CNI Role Improvements

* Add meta for Ansible Kubernetes Collections
* Change `include_tasks` to `import_tasks` for ansible 2.7+
compatibility.
 [1] (ansible/ansible#46177)
 [2] (kubernetes-sigs/kubespray#3815)

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Change back to a include task

https://docs.ansible.com/ansible/latest/user_guide/playbooks_reuse.html

Aligns better with our current setup.

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Began adding automating to some of cilium values.

Currently debugging URL split

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Use regex from `cluster_controlplane_endpoint`

To template values for Cilium.

1. Update Cilium values
2. Point K8s to right config
3. Add tests

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Bump tag values and template enovy version.

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Drop cri_plugin for now

Also update inventory source and delegate to localhost.. also for now.

Change galaxy collection to new name.

https://github.com/ansible-collections/community.kubernetes/issues/221

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Install helm as a kubernete dependency

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Add openshift module as a dependency

This is required to leverage Kubernetes modules from ansible. Hopefully
this changes in the future.

According to git issues a .deb is planned. A RPM is available. There is
a package in the AUR though opted to install with PIP instead because I
would trust it better without testing.

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Remove hostname

Set in a more elegant multi-os manner later.

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Add community.general.modprobe as a requirement

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Drop FQCN, and test kubelt j2 logic

https://docs.cilium.io/en/v1.6/kubernetes/requirements/#enable-automatic-node-cidr-allocation-recommended

ansible/ansible#71824

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Enable automatic node CIDR allocation

https://docs.cilium.io/en/v1.6/kubernetes/requirements/#enable-automatic-node-cidr-allocation-recommended

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* allocate-node-cidrs is enabled by default

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Disable envoy version check

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Template out some variable values and disable BPF by default

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Remove old packages from Kubernetes role

This was dropped due to the latest merge and made it into the working
tree

#84

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Kube-Proxy revisions

Disable kube-proxy by default for cilium. Revise var handling.

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Revise eBPF mount

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Change default variables

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* fix docker restart handler

https://github.com/raspbernetes/k8s-cluster-installation/pull/92/files

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Begin adding sysctl fix and enable hubble by default

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Some polishes

* Revise requirements to correctly point to modules.
* Disable hubble by default. Users can, and probably should do this on
their
[own](https://docs.cilium.io/en/v1.9/gettingstarted/k8s-install-kubeadm/#enable-hubble-for-cluster-wide-visibility)
in the meantime we'll not support but leave the option there.
* Add sysctl's for present systemd bug - cilium/cilium#10645

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Scope out cilium variables to examples.

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

* Small cleanups

* Added var twice
* `---`

Signed-off-by: anthr76 <hello@anthonyrabbito.com>

Co-authored-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com>
Co-authored-by: anthr76 <hello@anthonyrabbito.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants