Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated provider, fix flatcar configs, enable CI tests and refactor hetzner terraform #10002

Merged
merged 5 commits into from
May 8, 2023
Merged

Remove deprecated provider, fix flatcar configs, enable CI tests and refactor hetzner terraform #10002

merged 5 commits into from
May 8, 2023

Conversation

ThisIsQasim
Copy link
Contributor

@ThisIsQasim ThisIsQasim commented Apr 19, 2023 •
edited by floryut
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The template terraform provider was deprecated hashicorp/terraform-provider-template#85 some time ago so binaries for new devices like the Apple Silicon Macs aren't available. This replaces the use of the provider with the built in templatefile function.
Enables terraform validation tests in the CI.
Also refactors and fixes the outdated code in the flatcar module which had been broken due to breaking changes upstream.
Lastly, this formats the hcl using terraform fmt

Which issue(s) this PR fixes:

Fixes #9961

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Refactor Hetzner terraform (fixing flatcar configs and remove deprecated provider)

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @ThisIsQasim. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 19, 2023
MrFreezeex
MrFreezeex approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this very nice cleanup :D
/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2023
@ThisIsQasim ThisIsQasim changed the title Remove deprecated provider, refactor and fix flatcar configs from hetzner terraform Remove deprecated provider, refactor, fix flatcar configs and enable CI tests for hetzner terraform Apr 19, 2023
@ThisIsQasim ThisIsQasim changed the title Remove deprecated provider, refactor, fix flatcar configs and enable CI tests for hetzner terraform Remove deprecated provider, fix flatcar configs, enable CI tests and refactor hetzner terraform Apr 19, 2023
@ThisIsQasim
Copy link
Contributor Author

I noticed the CI tests were missing for hetzner terraform so I have added them but that has removed the lgtm label. @MrFreezeex do you mind taking another look?

@MrFreezeex
Copy link
Member

MrFreezeex commented Apr 19, 2023 •
edited
Loading

I noticed the CI tests were missing for hetzner terraform so I have added them but that has removed the lgtm label. @MrFreezeex do you mind taking another look?

Sure, thanks for the extra test btw!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2023
@ThisIsQasim
Copy link
Contributor Author

Sure, thanks for the extra test btw!

Happy to contribute back!

@ThisIsQasim
Copy link
Contributor Author

I don’t plan on any further changes so this is ready for review/merge @holmsten @liupeng0518

@oomichi
Copy link
Contributor

oomichi commented Apr 25, 2023

Hello @florianow

You have put much your effort on hetzner terraform, so could you take a look at this pull request?

@ThisIsQasim
Copy link
Contributor Author

@florianow do you mind taking a look?

@holmsten @liupeng0518 @oomichi I noticed the the contributing guide mentions squashing commits. I had assumed the entire PR would be squashed before merging but please let me know if I should squash these commits

florianow
florianow approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@florianow florianow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contribute :)

@oomichi
Copy link
Contributor

oomichi commented May 8, 2023

LGTM, thanks for contribute :)

Thanks for checking this pull request @florianow

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: florianow, MrFreezeex, oomichi, ThisIsQasim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit ab6d204 into kubernetes-sigs:master May 8, 2023
@ThisIsQasim ThisIsQasim deleted the hetzner branch May 8, 2023 05:52
@floryut floryut added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 9, 2023
@eddydecena eddydecena mentioned this pull request May 14, 2023
Closed
@yankay yankay mentioned this pull request May 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@ThisIsQasim @pedromcpedro
Remove deprecated provider, fix flatcar configs, enable CI tests and …
8e0062f 
…refactor hetzner terraform (kubernetes-sigs#10002)

* Remove deprecated provider and fix flatcar configs

* Refactor for DRYness

* Add missing line endings

* Enable tests for hetzner terraform in CI

* Add missing inventory for CI tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@florianow florianow florianow approved these changes

@holmsten holmsten Awaiting requested review from holmsten

@liupeng0518 liupeng0518 Awaiting requested review from liupeng0518

Assignees

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hetzner terraform does not work on M1 mac
6 participants
@ThisIsQasim @k8s-ci-robot @MrFreezeex @oomichi @florianow @floryut