[MetalLB] Remove unused resources

[eugene-marchanka]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Fix cluster deployment when MetalLB settings are specified

Which issue(s) this PR fixes:

Fixes #10003

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Cleanup MetalLB install following update

[k8s-ci-robot]

Hi @eugene-marchanka. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[oomichi]

Nice cleanup, the places of metallb_ip_range have been removed since the commit 709ae1d

/ok-to-test
/approve

[eugene-marchanka]

I'm still getting weird errors when deploying.
Potentially there are more bugs in it

[oomichi]

The scope of this pull request is changed after my review.
If you need to fix different issue of metallb, could you please try #9995 ?

/approve cancel

[eugene-marchanka]

The scope of this pull request is changed after my review. If you need to fix different issue of metallb, could you please try #9995 ?

/approve cancel

reverted

[floryut]

@eugene-marchanka Ok all good after revert, @oomichi wilm probably lgtm when dropping by 👍

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eugene-marchanka, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[luna-xenia]

I'm getting the following error trying to use this branch:

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'controller'
failed: [msh-k8s-c1-1] (item=metallb.yml) => {"ansible_loop_var": "item", "changed": false, "item": "metallb.yml", "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'controller'"}
changed: [msh-k8s-c1-1] => (item=pools.yaml)
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'layer2'
failed: [msh-k8s-c1-1] (item=layer2.yaml) => {"ansible_loop_var": "item", "changed": false, "item": "layer2.yaml", "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'layer2'"}
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'defaults'
failed: [msh-k8s-c1-1] (item=layer3.yaml) => {"ansible_loop_var": "item", "changed": false, "item": "layer3.yaml", "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'defaults'"}

My addons.yml has the following content for MetalLB:

metallb_protocol: "bgp"
metallb_config:
  address_pools:
    primary:
      ip_range:
        - 10.5.0.0/16
      auto_assign: true
  layer3:
    metallb_peers:
      peer1:
        peer_address: 10.0.50.1
        peer_asn: 65000
        my_asn: 65001
        address_pool:
          - primary

Could be my issue though if I'm doing something wrong here

[luna-xenia]

With metallb_speaker_enabled: true and defaults set at their default value I get the following error, not sure if this is part of this PR or not but thought it was worth mentioning:

TASK [kubernetes-apps/metallb : Kubernetes Apps | Check BGP peers for MetalLB] ************************************************************************************************************************************
fatal: [msh-k8s-c1-1]: FAILED! => {"changed": false, "msg": "metallb_peers is mandatory when metallb_protocol is bgp and metallb_speaker_enabled"}

[eugene-marchanka]

With metallb_speaker_enabled: true and defaults set at their default value I get the following error, not sure if this is part of this PR or not but thought it was worth mentioning:

TASK [kubernetes-apps/metallb : Kubernetes Apps | Check BGP peers for MetalLB] ************************************************************************************************************************************
fatal: [msh-k8s-c1-1]: FAILED! => {"changed": false, "msg": "metallb_peers is mandatory when metallb_protocol is bgp and metallb_speaker_enabled"}

I'm very sorry but unfortunately issues you are describing are out of this PR scope.
Check this: #9995

[luna-xenia]

Thank you that is what I assumed

[oomichi]

Thanks for making this simple.

/lgtm

[oomichi]

A nice catch for non-existent metallb-config.yml.j2 under ./roles/kubernetes-apps/metallb/templates/

[Jeroen0494]

This was already being addressed here: #9995
I rebased.