Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Update metrics server to v0.6.3 #10026

Merged

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Apr 25, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:
Sync manifests with https://github.com/kubernetes-sigs/metrics-server/releases/download/v0.6.3/components.yaml
Upgrade metrics server to v0.6.3 release notes: https://github.com/kubernetes-sigs/metrics-server/releases/tag/v0.6.3

Does this PR introduce a user-facing change?:

Update metrics server to v0.6.3

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 25, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2023
@mzaian mzaian force-pushed the update-metrics-server-v0.6.3 branch from 837314f to d582a1f Compare April 26, 2023 08:14
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! :D
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a505a4c into kubernetes-sigs:master Apr 26, 2023
@yankay yankay mentioned this pull request May 15, 2023
@Jeroen0494
Copy link
Contributor

Jeroen0494 commented Jun 9, 2023

This PR has caused some issues:

[2023-06-09T13:45:31.395Z] TASK [download : download_container | Load image into the local container registry] ***
[2023-06-09T13:45:31.395Z] Friday 09 June 2023  15:45:31 +0200 (0:00:02.194)       0:12:46.108 *********** 
[2023-06-09T13:45:31.972Z] fatal: [acc-bg-ot-k8sm001]: FAILED! => changed=true 
[2023-06-09T13:45:31.972Z]   cmd: /usr/local/bin/nerdctl -n k8s.io image load < /tmp/releases/images/registry.k8s.io_metrics-server_metrics-server_v0.6.3.tar
[2023-06-09T13:45:31.972Z]   delta: '0:00:00.071411'
[2023-06-09T13:45:31.972Z]   end: '2023-06-09 15:45:31.768971'
[2023-06-09T13:45:31.972Z]   failed_when_result: true
[2023-06-09T13:45:31.972Z]   msg: non-zero return code
[2023-06-09T13:45:31.972Z]   rc: 1
[2023-06-09T13:45:31.972Z]   start: '2023-06-09 15:45:31.697560'
[2023-06-09T13:45:31.972Z]   stderr: 'time="2023-06-09T15:45:31+02:00" level=fatal msg="failed to ingest \"blobs/sha256/10f855b03c8aee4fb0b9b7031c333640d684bd9ee6045f11f9892c7fea394701\": failed to read expected number of bytes: unexpected EOF"'
[2023-06-09T13:45:31.972Z]   stderr_lines: <omitted>
[2023-06-09T13:45:31.972Z]   stdout: ''
[2023-06-09T13:45:31.972Z]   stdout_lines: <omitted>
[2023-06-09T13:45:31.972Z] fatal: [acc-bg-ot-k8sm002]: FAILED! => changed=true 
[2023-06-09T13:45:31.972Z]   cmd: /usr/local/bin/nerdctl -n k8s.io image load < /tmp/releases/images/registry.k8s.io_metrics-server_metrics-server_v0.6.3.tar
[2023-06-09T13:45:31.972Z]   delta: '0:00:00.109713'
[2023-06-09T13:45:31.972Z]   end: '2023-06-09 15:45:31.851894'
[2023-06-09T13:45:31.972Z]   failed_when_result: true
[2023-06-09T13:45:31.972Z]   msg: non-zero return code
[2023-06-09T13:45:31.972Z]   rc: 1
[2023-06-09T13:45:31.972Z]   start: '2023-06-09 15:45:31.742181'
[2023-06-09T13:45:31.972Z]   stderr: 'time="2023-06-09T15:45:31+02:00" level=fatal msg="failed to ingest \"blobs/sha256/10f855b03c8aee4fb0b9b7031c333640d684bd9ee6045f11f9892c7fea394701\": failed to read expected number of bytes: unexpected EOF"'
[2023-06-09T13:45:31.972Z]   stderr_lines: <omitted>
[2023-06-09T13:45:31.972Z]   stdout: ''
[2023-06-09T13:45:31.972Z]   stdout_lines: <omitted>
[2023-06-09T13:45:31.972Z] 
[2023-06-09T13:45:31.972Z] NO MORE HOSTS LEFT *************************************************************

The file downloaded is 1.5Kb in size, way to small. When removing the file, the error is a little bit different:


[2023-06-09T14:17:21.876Z] TASK [download : download_container | Save and compress image] *****************
[2023-06-09T14:17:21.876Z] Friday 09 June 2023  16:17:21 +0200 (0:00:01.993)       0:10:58.332 *********** 
[2023-06-09T14:17:22.451Z] fatal: [acc-bg-ot-k8sm001 -> localhost]: FAILED! => changed=true 
[2023-06-09T14:17:22.451Z]   cmd: /usr/local/bin/ctr -n k8s.io image export --platform linux/amd64 /var/lib/jenkins/kubespray_cache/images/registry.k8s.io_metrics-server_metrics-server_v0.6.3.tar registry.k8s.io/metrics-server/metrics-server:v0.6.3
[2023-06-09T14:17:22.451Z]   delta: '0:00:00.071164'
[2023-06-09T14:17:22.451Z]   end: '2023-06-09 16:17:22.348691'
[2023-06-09T14:17:22.451Z]   failed_when_result: true
[2023-06-09T14:17:22.451Z]   msg: non-zero return code
[2023-06-09T14:17:22.451Z]   rc: 1
[2023-06-09T14:17:22.451Z]   start: '2023-06-09 16:17:22.277527'
[2023-06-09T14:17:22.451Z]   stderr: 'ctr: failed to get reader: content digest sha256:10f855b03c8aee4fb0b9b7031c333640d684bd9ee6045f11f9892c7fea394701: not found'
[2023-06-09T14:17:22.451Z]   stderr_lines: <omitted>
[2023-06-09T14:17:22.451Z]   stdout: ''
[2023-06-09T14:17:22.451Z]   stdout_lines: <omitted>
[2023-06-09T14:17:22.451Z] 
[2023-06-09T14:17:22.451Z] NO MORE HOSTS LEFT *************************************************************

@Jeroen0494
Copy link
Contributor

Looks like the download went wrong somewhere:

jenkins@jenkins-worker-002:~/kubespray_cache/images$ sudo ctr -n k8s.io image export registry.k8s.io_metrics-server_metrics-server_v0.6.3.tar registry.k8s.io/metrics-server/metrics-server:v0.6.3
ctr: failed to get reader: content digest sha256:10f855b03c8aee4fb0b9b7031c333640d684bd9ee6045f11f9892c7fea394701: not found

jenkins@jenkins-worker-002:~/kubespray_cache/images$ sudo ctr -n k8s.io image rm registry.k8s.io/metrics-server/metrics-server:v0.6.3
registry.k8s.io/metrics-server/metrics-server:v0.6.3
jenkins@jenkins-worker-002:~/kubespray_cache/images$ sudo ctr -n k8s.io image pull registry.k8s.io/metrics-server/metrics-server:v0.6.3
registry.k8s.io/metrics-server/metrics-server:v0.6.3:                             resolved       |++++++++++++++++++++++++++++++++++++++| 
index-sha256:c60778fa1c44d0c5a0c4530ebe83f9243ee6fc02f4c3dc59226c201931350b10:    exists         |++++++++++++++++++++++++++++++++++++++| 
manifest-sha256:3e7fce61907e003ef8734cc6a39195228002d9b2d64c3fe3b7593f9d448ea133: exists         |++++++++++++++++++++++++++++++++++++++| 
config-sha256:817bbe3f2e5179b5fa7dd4085c87aab1faaf9dc879e3b1d05796901a006f58ab:   exists         |++++++++++++++++++++++++++++++++++++++| 
layer-sha256:d7f870112e68a947c3e58ef5d7fe1e246c70cb07e7ffd598605e563f3c796436:    exists         |++++++++++++++++++++++++++++++++++++++| 
layer-sha256:e8c73c638ae9ec5ad70c49df7e484040d889cca6b4a9af056579c3d058ea93f0:    exists         |++++++++++++++++++++++++++++++++++++++| 
layer-sha256:1e3d9b7d145208fa8fa3ee1c9612d0adaac7255f1bbc9ddea7e461e0b317805c:    exists         |++++++++++++++++++++++++++++++++++++++| 
layer-sha256:4aa0ea1413d37a58615488592a0b827ea4b2e48fa5a77cf707d0e35f025e613f:    exists         |++++++++++++++++++++++++++++++++++++++| 
layer-sha256:7c881f9ab25e0d86562a123b5fb56aebf8aa0ddd7d48ef602faf8d1e7cf43d8c:    exists         |++++++++++++++++++++++++++++++++++++++| 
layer-sha256:5627a970d25e752d971a501ec7e35d0d6fdcd4a3ce9e958715a686853024794a:    exists         |++++++++++++++++++++++++++++++++++++++| 
layer-sha256:fe5ca62666f04366c8e7f605aa82997d71320183e99962fa76b3209fdfbb8b58:    exists         |++++++++++++++++++++++++++++++++++++++| 
layer-sha256:b438aade392267e4f99f3bac4b6c46de104f45b105c930014a9045b426b1cec1:    exists         |++++++++++++++++++++++++++++++++++++++| 
layer-sha256:fcb6f6d2c9986d9cd6a2ea3cc2936e5fc613e09f1af9042329011e43057f3265:    exists         |++++++++++++++++++++++++++++++++++++++| 
layer-sha256:10f855b03c8aee4fb0b9b7031c333640d684bd9ee6045f11f9892c7fea394701:    done           |++++++++++++++++++++++++++++++++++++++| 
elapsed: 1.6 s                                                                    total:   0.0 B (0.0 B/s)                                         
unpacking linux/amd64 sha256:c60778fa1c44d0c5a0c4530ebe83f9243ee6fc02f4c3dc59226c201931350b10...
done: 37.383078ms
jenkins@jenkins-worker-002:~/kubespray_cache/images$ sudo ctr -n k8s.io image export registry.k8s.io_metrics-server_metrics-server_v0.6.3.tar registry.k8s.io/metrics-server/metrics-server:v0.6.3

@mzaian
Copy link
Contributor Author

mzaian commented Jun 9, 2023

Hello @Jeroen0494

What does the errors you're encountering has to do with this PR? I think you have a different problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants