Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flannel image repo #10041

Merged
merged 1 commit into from
May 7, 2023
Merged

Update flannel image repo #10041

merged 1 commit into from
May 7, 2023

Conversation

ErikJiang
Copy link
Member

@ErikJiang ErikJiang commented May 4, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
I was trying to pull the flannel image repo, but it seems like it's no longer available. I did find out that the latest tag version of flannelcni/flannel is only v0.21.0, but apparently, it needs to be changed to flannel/flannel.
image

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[flannel] Update image repo from flannelcni to flannel

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2023
@yankay
Copy link
Member

yankay commented May 4, 2023

Thanks @ErikJiang
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@ErikJiang
Copy link
Member Author

@mzaian @jayonlau @MrFreezeex PTAL 😊

@mzaian
Copy link
Contributor

mzaian commented May 4, 2023

@mzaian @jayonlau @MrFreezeex PTAL 😊

I think we are mirroring flannel to kubespray quai io so this is maybe why the path is still correct.

/cc @floryut

@k8s-ci-robot k8s-ci-robot requested a review from floryut May 4, 2023 09:05
@@ -1001,7 +1001,7 @@ skopeo_binary_checksum: "{{ skopeo_binary_checksums[image_arch][skopeo_version]
kube_proxy_image_repo: "{{ kube_image_repo }}/kube-proxy"
etcd_image_repo: "{{ quay_image_repo }}/coreos/etcd"
etcd_image_tag: "{{ etcd_version }}"
flannel_image_repo: "{{ docker_image_repo }}/flannelcni/flannel"
flannel_image_repo: "{{ docker_image_repo }}/flannel/flannel"
flannel_image_tag: "{{ flannel_version }}"
flannel_init_image_repo: "{{ docker_image_repo }}/flannelcni/flannel-cni-plugin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @ErikJiang
Should the flannel_init_image_repo change together?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may not be possible to change it because the v1.2.0 image is not found in flannel/flannel-cni-plugin.

@ErikJiang
Copy link
Member Author

@floryut PTAL 😊

@oomichi
Copy link
Contributor

oomichi commented May 7, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ErikJiang, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 426b891 into kubernetes-sigs:master May 7, 2023
57 checks passed
@floryut floryut added kind/network Network section in the release note and removed kind/bug Categorizes issue or PR as related to a bug. labels May 9, 2023
@yankay yankay mentioned this pull request May 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants