-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add provider meta module_name in Equinix Metal TF configs #10044
Add provider meta module_name in Equinix Metal TF configs #10044
Conversation
Welcome @Vasubabu! |
Hi @Vasubabu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
091626c
to
76181fc
Compare
6f13f4e
to
27e809c
Compare
docs/ci-setup.md
Outdated
|
||
# standalone etcds | ||
number_of_etcd = 0 | ||
|
||
plan_etcd = "t1.small.x86" | ||
|
||
# masters | ||
# masters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# masters | |
# masters |
Spacing in these changes is offending the linter. It's hard to tell from the GitHub view, but it appears as though there are hundreds of spaces after the word masters
. After addressing this, amend commit (keeping the PR as a single commit) and force push to avoid creating commit noise for this unintended change.
Please do the following to test this locally:
$ npm install -g markdownlint-cli@0.22.0
added 36 packages in 2s
2 packages are looking for funding
run `npm fund` for details
$ markdownlint $(find . -name '*.md' | grep -vF './.git') --ignore docs/_sidebar.md --ignore contrib/dind/README.md
./docs/ci-setup.md:58:10 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 109]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keeping the PR as a single commit
One or two separate commits. As two it would be one for the UA prefix and another for the facility to metro changes.
The PR description should mention why this is being done (facility deprecation):
https://feedback.equinixmetal.com/changelog/bye-facilities-hello-again-metros
6f7d68c
to
e46c7e0
Compare
We'll want to update the two test variable references from facility to metro with the appropriate metro setting. ( |
It looks like CI has been fixed in recently merged PRs. Rebasing this PR should help to get the tests passing again. |
31e3bd7
to
e93067c
Compare
e93067c
to
25cbd54
Compare
Thanks for your contribution! :D |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oomichi, vasubabu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Related to equinix/terraform-provider-equinix#252
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Related to equinix/terraform-provider-equinix#252