Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider meta module_name in Equinix Metal TF configs #10044

Merged
merged 1 commit into from
May 22, 2023

Conversation

codinja1188
Copy link
Contributor

@codinja1188 codinja1188 commented May 4, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation4
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

  • It allows Vendor to declare the metadata fields. It adds provider meta module_name in Equinix Metal TF configs.
  • To simplify user experience, we will replace the “facility” attribute in the Metal CLI and API with the “metro” attribute.

Related to equinix/terraform-provider-equinix#252

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add provider meta module_name in Equinix Metal TF configs

Related to equinix/terraform-provider-equinix#252

@k8s-ci-robot
Copy link
Contributor

Welcome @Vasubabu!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Vasubabu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 4, 2023
@codinja1188 codinja1188 changed the title Enabled module_name in provider meta Add provider meta module_name in Equinix Metal TF configs May 4, 2023
@displague
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 5, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 5, 2023
@codinja1188 codinja1188 force-pushed the VK_module_name branch 2 times, most recently from 6f13f4e to 27e809c Compare May 12, 2023 12:32
docs/ci-setup.md Outdated

# standalone etcds
number_of_etcd = 0

plan_etcd = "t1.small.x86"

# masters
# masters
Copy link
Member

@displague displague May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# masters
# masters

Spacing in these changes is offending the linter. It's hard to tell from the GitHub view, but it appears as though there are hundreds of spaces after the word masters. After addressing this, amend commit (keeping the PR as a single commit) and force push to avoid creating commit noise for this unintended change.

Please do the following to test this locally:

$ npm install -g markdownlint-cli@0.22.0
added 36 packages in 2s
2 packages are looking for funding
  run `npm fund` for details
$ markdownlint $(find . -name '*.md' | grep -vF './.git') --ignore docs/_sidebar.md --ignore contrib/dind/README.md
./docs/ci-setup.md:58:10 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 109]

Copy link
Member

@displague displague May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping the PR as a single commit

One or two separate commits. As two it would be one for the UA prefix and another for the facility to metro changes.

The PR description should mention why this is being done (facility deprecation):
https://feedback.equinixmetal.com/changelog/bye-facilities-hello-again-metros

@codinja1188 codinja1188 force-pushed the VK_module_name branch 4 times, most recently from 6f7d68c to e46c7e0 Compare May 12, 2023 16:05
@displague
Copy link
Member

We'll want to update the two test variable references from facility to metro with the appropriate metro setting. (ewr1 -> ny, ams1 -> am, TF_VAR_facility -> TF_VAR_metro) in .gitlab-ci/terraform.yml

@displague
Copy link
Member

It looks like CI has been fixed in recently merged PRs. Rebasing this PR should help to get the tests passing again.

@codinja1188 codinja1188 force-pushed the VK_module_name branch 4 times, most recently from 31e3bd7 to e93067c Compare May 16, 2023 13:19
@MrFreezeex
Copy link
Member

Thanks for your contribution! :D
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2023
@displague
Copy link
Member

/lgtm

@oomichi
Copy link
Contributor

oomichi commented May 22, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, vasubabu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit feeea7e into kubernetes-sigs:master May 22, 2023
58 checks passed
@yankay yankay mentioned this pull request May 24, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants