Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coredns): coredns_rewrite_block to perform internal message rewriting #10045

Merged
merged 1 commit into from
May 12, 2023

Conversation

maxime1907
Copy link
Contributor

@maxime1907 maxime1907 commented May 4, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:
Adds a variable coredns_rewrite_block so that we can perform internal message rewriting.
It is really useful when we want for instance multiple internal domain names that resolve to cluster.local:

rewrite stop {
  name regex (.*)\.my\.domain {1}.svc.cluster.local
  answer name (.*)\.svc\.cluster\.local {1}.my.domain
}

Does this PR introduce a user-facing change?:

Add `coredns_rewrite_block` to perform internal message rewriting

…iting

Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @maxime1907. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 4, 2023
@yankay
Copy link
Member

yankay commented May 6, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2023
@oomichi
Copy link
Contributor

oomichi commented May 8, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxime1907 Thank you for the PR 🙇
/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, maxime1907

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2023
@oomichi
Copy link
Contributor

oomichi commented May 10, 2023

/ok-to-test

@oomichi
Copy link
Contributor

oomichi commented May 12, 2023

To kick CI jobs again.

@oomichi oomichi closed this May 12, 2023
@oomichi oomichi reopened this May 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4ffe138 into kubernetes-sigs:master May 12, 2023
56 checks passed
@yankay yankay mentioned this pull request May 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
…iting (kubernetes-sigs#10045)

Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants