Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump cni version to v1.3.0 #10058

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

cyclinder
Copy link
Contributor

@cyclinder cyclinder commented May 10, 2023

Signed-off-by: cyclinder qifeng.guo@daocloud.io

What type of PR is this?

/kind feature

What this PR does / why we need it:
bump cni version to v1.3.0
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Upgrade cni version to v1.3.0

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 10, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 10, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 10, 2023
@yankay
Copy link
Member

yankay commented May 15, 2023

The CI seems broken, it may need push again.

@cyclinder cyclinder force-pushed the cni/v1-3-0 branch 2 times, most recently from 3585dcf to 9c702f3 Compare May 15, 2023 07:05
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 15, 2023
@MrFreezeex
Copy link
Member

Hi @cyclinder, you need to rebase the PR to fix the CI issue

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 15, 2023
@MrFreezeex
Copy link
Member

CI flakes again you are not very lucky :(. If you amend your commit without changing anything + push force it should work this time (hopefully)

@cyclinder cyclinder force-pushed the cni/v1-3-0 branch 4 times, most recently from 18ecefc to 39bb158 Compare May 16, 2023 09:10
Signed-off-by: cyclinder qifeng.guo@daocloud.io
@cyclinder
Copy link
Contributor Author

All tests passed, It's time to merge ~~

/cc @MrFreezeex @floryut

@MrFreezeex
Copy link
Member

Thanks :D
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2023
@oomichi
Copy link
Contributor

oomichi commented May 17, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyclinder, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit a257e61 into kubernetes-sigs:master May 17, 2023
58 checks passed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Signed-off-by: cyclinder qifeng.guo@daocloud.io

Signed-off-by: cyclinder qifeng.guo@daocloud.io
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants