Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI_BUILD_ID to CI_JOB_ID #10063

Merged

Conversation

floryut
Copy link
Member

@floryut floryut commented May 10, 2023

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
Update CI_BUILD_ID var to CI_JOB_ID

Which issue(s) this PR fixes:
Fixes failing jobs, ie: https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/4262404058
https://docs.gitlab.com/ee/update/deprecations.html#ci_build_-predefined-variables

The predefined CI/CD variables that start with CI_BUILD_* were deprecated in GitLab 9.0, and will be removed in GitLab 16.0. If you still use these variables, be sure to change to the replacement predefined variables which are functionally identical

Special notes for your reviewer:
CI_BUILD_ID var has been removed from gitlab codebase https://gitlab.com/gitlab-org/gitlab/-/issues/389376
gitlab instance has migrate to a new version shipping that change.

Does this PR introduce a user-facing change?:

[CI] Migrate CI_BUILD_ID to CI_JOB_ID and CI_BUILD_REF to CI_COMMIT_SHA following gitlab upgrade

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@MrFreezeex
Copy link
Member

MrFreezeex commented May 10, 2023

Nice! Thanks 🎉
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2023
@oomichi
Copy link
Contributor

oomichi commented May 11, 2023

packet_debian11-calico-upgrade is failed like

...
HEAD is now at c4346e590 kubeadm/etcd: use config to download certificate (#9609)
+ test graceful '!=' false
./tests/scripts/testcases_run.sh: line 60: CI_BUILD_REF: unbound variable
Running after_script
00:13
Running after script...
$ chronic ./tests/scripts/testcases_cleanup.sh
Uploading artifacts for failed job
00:02
Uploading artifacts...
cluster-dump: found 6 matching artifact files and directories 
Uploading artifacts as "archive" to coordinator... 201 Created  id=4262966526 responseStatus=201 Created token=64_sYsmz
Cleaning up project directory and file based variables
00:01
ERROR: Job failed: command terminated with exit code 1

I guess CI_BUILD_REF also needs to be repreced with CI_COMMIT_SHA according to https://docs.gitlab.com/ee/update/deprecations.html#ci_build_-predefined-variables

@floryut
Copy link
Member Author

floryut commented May 11, 2023

Damn, thank you @oomichi

@floryut floryut force-pushed the fix/migrate_cibuildid_var branch from 2cb26e7 to 4fae691 Compare May 11, 2023 09:15
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2023
@mzaian
Copy link
Contributor

mzaian commented May 11, 2023

Thanks @floryut As I was following so I reviewed this and it looks good to me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 951face into kubernetes-sigs:master May 11, 2023
58 checks passed
@yankay yankay mentioned this pull request May 15, 2023
k8s-ci-robot pushed a commit that referenced this pull request Dec 1, 2023
* Convert exoscale tf provider to new version (#10646)

This is untested. It passes terraform validate to un-broke the CI.

* specify pyyaml version to 5.3.1

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>

* Migrate CI_BUILD_ID to CI_JOB_ID and CI_BUILD_REF to CI_COMMIT_SHA (#10063)

* Use supported version of fedora in CI (#10108)

* tests: replace fedora35 with fedora37

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* tests: replace fedora36 with fedora38

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* docs: update fedora version in docs

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* molecule: upgrade fedora version

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* tests: upgrade fedora images for vagrant and kubevirt

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* vagrant: workaround to fix private network ip address in fedora

Fedora stop supporting syconfig network script so we added a workaround
here
hashicorp/vagrant#12762 (comment)
to fix it.

* netowrkmanager: do not configure dns if using systemd-resolved

We should not configure dns if we point to systemd-resolved.
Systemd-resolved is using NetworkManager to infer the upstream DNS
server so if we set NetworkManager to 127.0.0.53 it will prevent
systemd-resolved to get the correct network DNS server.

Thus if we are in this case we just don't set this setting.

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* image-builder: update centos7 image

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* gitlab-ci: mark fedora packet jobs as allow failure

Fedora networking is still broken on Packet, let's mark it as allow
failure for now.

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

---------

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

---------

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
Co-authored-by: Max Gautier <mg@max.gautier.name>
Co-authored-by: Florian Ruynat <16313165+floryut@users.noreply.github.com>
Co-authored-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants