-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove end of life ubuntu versions in CI #10107
Remove end of life ubuntu versions in CI #10107
Conversation
f84db73
to
5ae41a2
Compare
6bfb182
to
08ecd1e
Compare
Thank you for doing this. /lgtm |
08ecd1e
to
6dce408
Compare
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
6dce408
to
b80c5fa
Compare
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
b80c5fa
to
ec93748
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MrFreezeex Could you please remove Ubuntu 16/18 from the README ?
I think I already did 🤔 https://github.com/kubernetes-sigs/kubespray/pull/10107/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R146 but maybe you meant something else? |
Oh, not sure how I missed that 😆 |
/lgtm |
* tests: replace ubuntu16 with ubuntu20 Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch> * tests: replace ubuntu18 with ubuntu20 Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch> * docs: update docs to remove support for ubuntu 16 and 18 Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch> * molecule: upgrade ubuntu versions Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch> * vagrant: upgrade ubuntu versions Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch> * tests: cleanup ubuntu{16,18} Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch> * tests: increase ubuntu22 ram to allow molecule creation Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch> --------- Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Replace ubuntu{16,18} tests by ubuntu20
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Ubuntu 16 is end of life for a while and ubuntu 18 is end of life the 31th may so IMO we don't need to bother supporting it anymore...
Does this PR introduce a user-facing change?: