Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating metallb config if unnecessary #10152

Closed
wants to merge 1 commit into from

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented May 30, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

To avoid the following error during setting metallb up, this adds some conditions:

 TASK [kubernetes_sigs.kubespray.kubernetes-apps/metallb : Kubernetes Apps | Lay Down MetalLB] ***
 [..]
  An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'controller'
  failed: [k8s-master-1] (item=metallb.yml) => {"ansible_loop_var": "item", "changed": false, "item": "metallb.yml", "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'controller'"}
  An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'layer3'
  failed: [k8s-master-1] (item=layer3.yaml) => {"ansible_loop_var": "item", "changed": false, "item": "layer3.yaml", "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'layer3'"}

Which issue(s) this PR fixes:

Fixes #10143

Does this PR introduce a user-facing change?:

Avoid creating metallb config if unnecessary

To avoid the following error during setting metallb up, this adds
some conditions:

 TASK [kubernetes_sigs.kubespray.kubernetes-apps/metallb : Kubernetes Apps | Lay Down MetalLB] ***
 [..]
  An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'controller'
  failed: [k8s-master-1] (item=metallb.yml) => {"ansible_loop_var": "item", "changed": false, "item": "metallb.yml", "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'controller'"}
  An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'layer3'
  failed: [k8s-master-1] (item=layer3.yaml) => {"ansible_loop_var": "item", "changed": false, "item": "layer3.yaml", "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'layer3'"}
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2023
@Jeroen0494
Copy link
Contributor

Will be fixed in #9995

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2023
@oomichi
Copy link
Contributor Author

oomichi commented Jun 1, 2023

Will be fixed in #9995

Thanks for pointing it out.
OK, let's close this pr.

@oomichi oomichi closed this Jun 1, 2023
@oomichi oomichi deleted the fix-metallb-config branch June 1, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error during task: Kubernetes Apps | Lay Down MetalLB
3 participants