Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flatcar] add python dependency check for helm-apps #10192

Conversation

palmeXx
Copy link
Contributor

@palmeXx palmeXx commented Jun 6, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:

helm-apps require PyYAML https://docs.ansible.com/ansible/latest/collections/kubernetes/core/helm_module.html as a dependency on the node where the Helm binaries are executed. The setup process does not install PyYAML during the OS bootstrapping, which can cause helm apps to fail due to missing dependencies.

 TASK [helm-apps : Add Helm repositories] ******************************************************************************************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ModuleNotFoundError: No module named 'yaml'
[WARNING]: Module did not set no_log for pass_credentials
failed: [cluster-k8s-az1-master1] (item={'name': 'kubelet-csr-approver', 'url': 'https://postfinance.github.io/kubelet-csr-approver'}) => {"ansible_loop_var": "item", "changed": false, "item": {"nam
e": "kubelet-csr-approver", "url": "https://postfinance.github.io/kubelet-csr-approver"}, "msg": "Failed to import the required Python library (yaml) on cluster-k8s-az1-master1's Python /opt/bin/pyt
hon. Please read the module documentation and install it in the appropriate location. If the required library is installed, but Ansible is using the wrong Python interpreter, please consult the documenta
tion on ansible_python_interpreter"}

The problem was encountered when activating kubelet_rotate_server_certificates with Flatcar as the operating system and kubespray release v2.22.0.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[flatcar] add python dependency check for helm-apps

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 6, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 6, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 6, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @palmeXx!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 6, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @palmeXx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 6, 2023
@MrFreezeex
Copy link
Member

Hi @palmeXx, thanks for your contribution however there is already a PR open for that: #10165

@dabeck dabeck mentioned this pull request Jun 6, 2023
@palmeXx
Copy link
Contributor Author

palmeXx commented Jun 6, 2023

Hi @palmeXx, thanks for your contribution however there is already a PR open for that: #10165
Hi, i missed this pr.

Issue: This does not address the dependencies on Flatcar as there is no package manager available for installing the pyyaml package.

@MrFreezeex
Copy link
Member

MrFreezeex commented Jun 6, 2023

Hmmm indeed it does not, could you then make this flatcar specific? IMO installing system wide packages via pip is a rather bad idea but I am fine it it's only a workaround for flatcar and possibly other distros that doesn't package it.

@palmeXx
Copy link
Contributor Author

palmeXx commented Jun 6, 2023

i'm with you...
I will prepare a solution

@MrFreezeex
Copy link
Member

FYI the other PR has been merged so please rebase your commit and also squash them if necessary and make it obvious it's for flatcar in the first commit title/PR title (or distros where pyyaml is not packaged if you find any and willing to do that, which is fine if you don't).

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2023
@palmeXx palmeXx closed this Jun 7, 2023
@palmeXx palmeXx force-pushed the fix/helm-apps-possible-missing-dependencies branch from e593a2b to 4c76feb Compare June 7, 2023 06:28
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2023
@palmeXx palmeXx reopened this Jun 7, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 7, 2023
@palmeXx palmeXx changed the title add python dependency check for helm-apps [flatcar] add python dependency check for helm-apps Jun 7, 2023
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and all the change :D!
/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2023
@floryut floryut added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jun 8, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2023
@palmeXx palmeXx requested a review from floryut June 8, 2023 12:18
@MrFreezeex
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2023
@oomichi
Copy link
Contributor

oomichi commented Jun 13, 2023

Thanks for your contribution @palmeXx
After reviewing #10204 I guessed we could have the same simple way for Flatcar also.
But that is already discussed in this pull request, so looks good for me.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, oomichi, palmeXx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 775851b into kubernetes-sigs:master Jun 13, 2023
60 checks passed
maciej-markowski pushed a commit to maciej-markowski/kubespray that referenced this pull request Jun 23, 2023
…10192)

* add pyyaml install via task instead of package

* Change condition for better consistency in the codebase
@yankay yankay mentioned this pull request Aug 24, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
…10192)

* add pyyaml install via task instead of package

* Change condition for better consistency in the codebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants