Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gce-pd-csi driver #10208

Merged

Conversation

ashishsinghdev
Copy link
Contributor

@ashishsinghdev ashishsinghdev commented Jun 9, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes below mentioned issues:
In release version v2.22.0/1, gce-pde-csi driver is not working due to below mentioned reasons.

Old gce-pd-csi driver version
Missing Kind: CSIDriver in current manifests files, which is required to run external CSI driver in Kubernetes version 1.18+
Need to sync manifests from original gce-pd csi driver repo, https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver

Which issue(s) this PR fixes:

Fixes #10207

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix gce-pd-csi driver 

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @ashishsinghdev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 9, 2023
@ashishsinghdev
Copy link
Contributor Author

@MrFreezeex Could you please have a quick look?

Tested on GCP, working fluently with these changes.

https://snipboard.io/i4VjnQ.jpg
https://snipboard.io/BKrEgj.jpg

@MrFreezeex
Copy link
Member

Hi, thanks, it looks very good 🙏 ❤️! You just need to update the version in the README of gcp-pd-csi-plugin (line 194) to make the CI happy.

@ashishsinghdev
Copy link
Contributor Author

Hi, thanks, it looks very good pray heart! You just need to update the version in the README of gcp-pd-csi-plugin (line 194) to make the CI happy.

Done

Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, your contribution is much appreciated 🙏
/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2023
@ashishsinghdev
Copy link
Contributor Author

/assign @LuckySB

@yankay
Copy link
Member

yankay commented Jun 12, 2023

Thanks @ashishsinghdev for update

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashishsinghdev, MrFreezeex, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit fc5937e into kubernetes-sigs:master Jun 12, 2023
60 checks passed
@floryut floryut added the kind/bug Categorizes issue or PR as related to a bug. label Jun 19, 2023
maciej-markowski pushed a commit to maciej-markowski/kubespray that referenced this pull request Jun 23, 2023
* fix gce-pd-csi driver

* fixed, 1. reading replicas value from defaults.yml, and 2. corrected gcp-pd-csi driver version in README.md
@yankay yankay mentioned this pull request Aug 24, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
* fix gce-pd-csi driver

* fixed, 1. reading replicas value from defaults.yml, and 2. corrected gcp-pd-csi driver version in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix gce-pd-csi driver in kubernetes-app role: PSP, CSIDriver, etc fixes
6 participants