Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set SSL_CERT_FILE for offline installation using custom CA for https proxy #10215

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

HappyFX
Copy link
Contributor

@HappyFX HappyFX commented Jun 12, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Add option to pass in environment SSL_CERT_FILE to use custom CA https_proxy

Which issue(s) this PR fixes:

Fixes #10214

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add option to set `SSL_CERT_FILE` for offline installation using custom CA for https proxy

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 12, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @HappyFX!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 12, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @HappyFX. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 12, 2023

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 12, 2023
@yankay
Copy link
Member

yankay commented Jun 15, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 15, 2023
@HappyFX
Copy link
Contributor Author

HappyFX commented Jun 15, 2023

Is it ok to add more verbosity in molecule tests with unsafe_show_logs: true?

@HappyFX HappyFX changed the title Happy fx patch 1 Add option to set SSL_CERT_FILE for offline installation using custom CA for https proxy Jun 15, 2023
@HappyFX
Copy link
Contributor Author

HappyFX commented Jun 20, 2023

@oomichi changed with suggestion https_proxy_cert_file

@HappyFX
Copy link
Contributor Author

HappyFX commented Jun 21, 2023

Have no idea why CI is failed on artefact push

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HappyFX Thank you for the PR, great desc/doc 🙇

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, HappyFX

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2023
@HappyFX
Copy link
Contributor Author

HappyFX commented Jun 22, 2023

All tests are passed. Can we merge or need some additional actions?

@yankay
Copy link
Member

yankay commented Jun 23, 2023

All tests are passed. Can we merge or need some additional actions?

Thanks @HappyFX

Nice PR!

Should the unsafe_show_logs be removed because it's not very useful as the default config,
And git squash the 14 git commits into 1.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 23, 2023
@HappyFX
Copy link
Contributor Author

HappyFX commented Jun 23, 2023

@yankay ready

@yankay
Copy link
Member

yankay commented Jun 23, 2023

Thanks @HappyFX

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2023
@MrFreezeex
Copy link
Member

/easycla

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@MrFreezeex
Copy link
Member

@HappyFX Can you check that your commit email address match the one on your GitHub profile (by changing it in the commit or adding it in GitHub probably)?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 23, 2023
@HappyFX
Copy link
Contributor Author

HappyFX commented Jun 23, 2023

changed commit email to github user and email
@MrFreezeex Now it's passed with EasyCLA

@MrFreezeex
Copy link
Member

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 180df83 into kubernetes-sigs:master Jun 23, 2023
60 checks passed
@HappyFX HappyFX deleted the HappyFX-patch-1 branch June 23, 2023 17:29
@yankay yankay mentioned this pull request Aug 24, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance isolated install
6 participants