Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI VM for debian12 #10222

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

yankay
Copy link
Member

@yankay yankay commented Jun 15, 2023

What type of PR is this?

/kind flake

What this PR does / why we need it:

To support debian12, add CI vm for the debian12 at: https://quay.io/kubespray/vm-debian-12

Support the #10221

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add CI VM for debian12 

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 15, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2023
@MrFreezeex
Copy link
Member

Ah wait I am confused actually the other PR have the same change isn't it?

@yankay
Copy link
Member Author

yankay commented Jun 15, 2023

Ah wait I am confused actually the other PR have the same change isn't it?

Hi @MrFreezeex

If the kubespray needs to add a new OS, the OS's kubevirt image needs to be build and update to the https://quay.io/organization/kubespray manually :-)

The PR is to build and image , and the image is still pushing. :-)
It will be pushed in a few hours (network is not fast) .

@MrFreezeex
Copy link
Member

Ohhhh ok I see thanks, for my curiosity I don't see any job on gitlab ci that would do that, so is it something that you invoke manually from your machine or?

Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @yankay

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, mzaian, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit efeac70 into kubernetes-sigs:master Jun 15, 2023
59 of 60 checks passed
@tu1h
Copy link
Member

tu1h commented Jun 16, 2023

Ah wait I am confused actually the other PR have the same change isn't it?

Hi @MrFreezeex

If the kubespray needs to add a new OS, the OS's kubevirt image needs to be build and update to the https://quay.io/organization/kubespray manually :-)

The PR is to build and image , and the image is still pushing. :-) It will be pushed in a few hours (network is not fast) .

I haven't been seen quay.io/kubespray/vm-debian-12 so far, I'm also curious about how it building and pushing :-)

@yankay
Copy link
Member Author

yankay commented Jun 16, 2023

Ah wait I am confused actually the other PR have the same change isn't it?

Hi @MrFreezeex
If the kubespray needs to add a new OS, the OS's kubevirt image needs to be build and update to the https://quay.io/organization/kubespray manually :-)
The PR is to build and image , and the image is still pushing. :-) It will be pushed in a few hours (network is not fast) .

I haven't been seen quay.io/kubespray/vm-debian-12 so far, I'm also curious about how it building and pushing :-)

Hi @tu1h

It's at https://quay.io/repository/kubespray/vm-debian-12?tab=tags&tag=latest

@yankay
Copy link
Member Author

yankay commented Jun 16, 2023

Thanks @MrFreezeex @mzaian for the PR review :-)

@tu1h
Copy link
Member

tu1h commented Jun 16, 2023

Ah wait I am confused actually the other PR have the same change isn't it?

Hi @MrFreezeex
If the kubespray needs to add a new OS, the OS's kubevirt image needs to be build and update to the https://quay.io/organization/kubespray manually :-)
The PR is to build and image , and the image is still pushing. :-) It will be pushed in a few hours (network is not fast) .

I haven't been seen quay.io/kubespray/vm-debian-12 so far, I'm also curious about how it building and pushing :-)

Hi @tu1h

It's at https://quay.io/repository/kubespray/vm-debian-12?tab=tags&tag=latest

It shows Repositorys not found to me when open the site. Are there some access restrictions?

CI still failed https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/4485281106

maciej-markowski pushed a commit to maciej-markowski/kubespray that referenced this pull request Jun 23, 2023
@yankay yankay mentioned this pull request Aug 24, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants