Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Calico to lowercase and fix broken calico link in README #10232

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

Xieql
Copy link
Contributor

@Xieql Xieql commented Jun 19, 2023

What type of PR is this?

/kind bug
/kind documentation

What this PR does / why we need it:

1 update ”Calico“ to lowercase so that it can maintain consistency in capitalization with other Network Plugins names in parallel.

2 update calico link in README

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update Calico to lowercase and fix broken calico link in README

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Xieql. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2023
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Xieql
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 19, 2023
@MrFreezeex
Copy link
Member

Hi @Xieql, thanks for the contribution! Could you rebase your commit, the CI failure seems weird 🤔

@Xieql
Copy link
Contributor Author

Xieql commented Jun 19, 2023

Okay, I noticed the error, but I wasn't sure why it occurred or how to handle it.

So, I performed ‘ git fetch --all ; git rebase upstream/master ’ and resubmitted the changes.

but still failed ...

@mzaian
Copy link
Contributor

mzaian commented Jun 19, 2023

Okay, I noticed the error, but I wasn't sure why it occurred or how to handle it.

So, I performed ‘ git fetch --all ; git rebase upstream/master ’ and resubmitted the changes.

but still failed ...

I the CI failures are not related to the rebasing. all good now let's wait and see.

@MrFreezeex
Copy link
Member

MrFreezeex commented Jun 19, 2023

Well actually I think that now that calico is lowercased the script to check if the versions in the readme are up to date is failing :(

@Xieql
Copy link
Contributor Author

Xieql commented Jun 19, 2023

Well actually I think that now that calico is lowercased the script to check if the versions in the readme are up to date is failing :(

Okay, I tried not to modify it to test your idea. However, I still think it looks strange to have "calico" in uppercase when all the other words are in lowercase.

@Xieql
Copy link
Contributor Author

Xieql commented Jun 19, 2023

still failed :(

@floryut
Copy link
Member

floryut commented Jun 19, 2023

still failed :(

That was a random one, I've restarted and this is now fixed

Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, there is two other pipelines that are running so there may be some other "random CI failiures" but we should get there bear with us 🙏 :D.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, mzaian, Xieql

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Xieql
Copy link
Contributor Author

Xieql commented Jun 19, 2023

I see. In that case, I will change "calico" back to lowercase. XD

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2023
@MrFreezeex
Copy link
Member

No but the lowercase calico definitely doesn't work with the script tests/scripts/check_readme_versions.sh :/, if you are willing to do so as well you might try to fix the script but it will be a bit more involved probably :(

Signed-off-by: Xieql <xieqianglong@huawei.com>
@MrFreezeex
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 41605b4 into kubernetes-sigs:master Jun 19, 2023
63 checks passed
maciej-markowski pushed a commit to maciej-markowski/kubespray that referenced this pull request Jun 23, 2023
Signed-off-by: Xieql <xieqianglong@huawei.com>
@yankay yankay mentioned this pull request Aug 24, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Signed-off-by: Xieql <xieqianglong@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants