Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix etcdctl copy operation in crio #10242

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix etcdctl copy operation in crio #10242

merged 1 commit into from
Jun 27, 2023

Conversation

ErikJiang
Copy link
Member

@ErikJiang ErikJiang commented Jun 21, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
Currently, crictl does not support the copy command, so I use cp /proc/${container_pid}/root/${file_path} to fix the etcdctl copy operation for now.

Which issue(s) this PR fixes:

Fixes #10240

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[cri-o] Fix etcdctl copy operation 

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2023
@k8s-ci-robot k8s-ci-robot requested review from EppO and yankay June 21, 2023 09:37
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🙏
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2023
@yckaolalala
Copy link
Contributor

AFAIK nerdctl can not run in crio.sock .
If want to copy etcdctl from image, need to start etcd in containerd and using nerdctl with containerd.sock ?

# CRI socket path
cri_socket: >-
  {%- if container_manager == 'crio' -%}
  unix:///var/run/crio/crio.sock
  {%- elif container_manager == 'containerd' -%}
  unix:///var/run/containerd/containerd.sock
  {%- elif container_manager == 'docker' -%}
  unix:///var/run/cri-dockerd.sock
  {%- endif -%}
  • roles/container-engine/nerdctl/templates/nerdctl.toml.j2
debug             = false
debug_full        = false
address           = "{{ cri_socket }}"

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2023
@ErikJiang
Copy link
Member Author

@yckaolalala You are right, nerdctl does not seem to be a good way, I modified the method to get etcdctl, please review it, thanks a lot😁

@ErikJiang
Copy link
Member Author

ErikJiang commented Jun 26, 2023

@MrFreezeex @yankay PTAL, Thanks 😊

@MrFreezeex
Copy link
Member

That's a nice trick :D
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2023
@oomichi
Copy link
Contributor

oomichi commented Jun 27, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ErikJiang, MrFreezeex, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2aafab6 into kubernetes-sigs:master Jun 27, 2023
63 checks passed
@yankay yankay mentioned this pull request Aug 24, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

etcdctl copy operation not work in crio
5 participants