Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubernetes] Add hashes for kubernetes 1.27.4, 1.26.7, 1.25.12 #10300

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Jul 20, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:
Add hashes for 1.27.4 1.26.7, 1.25.12
Make kubernetes v1.26.7 default

Does this PR introduce a user-facing change?:

Add hashes for 1.27.4 1.26.7, 1.25.12 and make kubernetes v1.26.7 default. 

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 20, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Jul 20, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 20, 2023
@mzaian mzaian force-pushed the k8s-1.27.4-hashes branch 3 times, most recently from 20a9ddb to dcc799c Compare July 20, 2023 09:21
@MrFreezeex
Copy link
Member

Hi! Btw did you use the script scripts/download_hash.sh it should automate this?

@mzaian
Copy link
Contributor Author

mzaian commented Jul 20, 2023

Hi! Btw did you use the script scripts/download_hash.sh it should automate this?

Yws, Using it but my connection is broken and slow. I think we need to alter it to only download new binaries and loop over all the existing ones. I will continue this later today.

@mzaian mzaian changed the title WIP [kubernetes] Add hashes for kubernetes 1.27.4, 1.26.7 ..etc [kubernetes] Add hashes for kubernetes 1.27.4, 1.26.7, 1.25.12 Jul 20, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Jul 20, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yankay
Copy link
Member

yankay commented Jul 24, 2023

Thanks @mzaian

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit fe32de9 into kubernetes-sigs:master Jul 24, 2023
63 checks passed
dabeck pushed a commit to fino-digital/kubespray that referenced this pull request Jul 24, 2023
@yankay yankay mentioned this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants