Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move runroot from crio.conf to storage.conf #10372

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

floryut
Copy link
Member

@floryut floryut commented Aug 17, 2023

What type of PR is this?
/kind container-managers

What this PR does / why we need it:
Fix crio jobs failing since moving to 1.27

Which issue(s) this PR fixes:
Fixes #10367

Special notes for your reviewer:
Got a thread in k8s slack https://kubernetes.slack.com/archives/CAZH62UR1/p1692279077580139
Will followup in the issue (or here) the exact root cause of this issue since 1.27

Does this PR introduce a user-facing change?:

[crio] `runroot` now needs to be setup in storage.conf instead of crio.conf

@k8s-ci-robot
Copy link
Contributor

@floryut: The label(s) kind/containers-manager cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind containers-manager

What this PR does / why we need it:
Fix crio jobs failing since moving to 1.27

Which issue(s) this PR fixes:
Fixes #10367

Special notes for your reviewer:
Got a thread in k8s slack https://kubernetes.slack.com/archives/CAZH62UR1/p1692279077580139
Will followup in the issue (or here) the exact root cause of this issue since 1.27

Does this PR introduce a user-facing change?:

[crio] `runroot` now needs to be setup in storage.conf instead of crio.conf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 17, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 17, 2023
@floryut floryut added the kind/container-managers Containers section in the release note label Aug 17, 2023
@mzaian
Copy link
Contributor

mzaian commented Aug 17, 2023

Thanks @floryut

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a8c1bcc into kubernetes-sigs:master Aug 17, 2023
63 checks passed
@yankay yankay mentioned this pull request Aug 24, 2023
guytet pushed a commit to guytet/kubespray that referenced this pull request Oct 30, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/container-managers Containers section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cri-o 1.27 unable to start in CI - Tests
3 participants